266581 - Replying or forwarding a message with inline images, fails to render images in the compose window

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Scott MacGregor]

Using 10/28 bits.

1) Reply or Forward a message that contains inline image elements. 
2) The compose window shows broken image icons for each image instead of the
actual image.

Note: The image is correctly sent out with the message when you send.

I suspect this is just some minor fall out from Bug #69070. I bet in the case of
reply/forward, we start loading the message in the compose window before the fix
for that bug changes the app type on the doc shell. I noticed that if I try to
manipulate the broken image icon in anyway, I can make the image show up for
real inside the compose window.

Comment 1

[Scott MacGregor]

Attachment: possible fix

This sets the docshell app type to editor instead of mail before inserting
reply/forwarded cotent into the compose window. Getting rid of the mail app
stuff made jst's change to become and editor app after inserting quoted
material simpler. 

The old code (Bug #167131, Bug #206793) (not related to jst's change) was
trying to keep us from loading remote images from a message if you were
blocking remote images from people you don't know in the message pane and you
reply or forward to the message (even though the images would eventually get
fetched when you pressed send anyway!). I guess I disagree with that so choose
to fix this bug by removing that code. If you are replying to the message your
privacy is going to be invalidated anyway.

Comment 2

[Scott MacGregor]

one point of clarification. This bug was blocking all images on the reply. Even
inline images that were part of the message. And it was blocking them even if
they were from people you know (which the message display layer allows yet mail
compose was not)

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 163773 [details] [diff] [review]
possible fix

You're the man to know how this should work, and this looks like it makes
things work the way you describe that you want them to work, so all good with
me :)

sr=jst

Comment 4

[Scott MacGregor]

thanks johnny.

fixed branch and trunk