266602 - sorting by priority in Tasks list is off

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Darryl C.]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040917 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040917 Firefox/0.9.3

When sorting using the priority column (!) the task order is off.

May be by design, but it's an annoyance once the task list gets filled up.


Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Actual Results:  
None, High, Medium, Low
or 
Low, Medium, High, None

Expected Results:  
High, Medium, Low, None
or 
None, Low, Medium, High

(possibly place None in between Low and medium? and even replace "None" with
"Normal")

Comment 1

[Wm]

for info: rfc2445 / 4.8.1.9 Priority (trimmed fo easier reading)
===
Description: The priority is specified as an integer in the range zero to nine.
A value of zero specifies an undefined priority. A value of one is the highest
priority. A value of two is the second highest priority. Subsequent numbers
specify a decreasing ordinal priority. A value of nine is the lowest priority.
===
so MozCal is following the rfc in that None (0) is _outside_ the High (1-3)
Medium (4-6) Low (7-9) range.  The existing sequence of None, High, Medium, Low
makes sense to me because tasks that have yet to be assigned a priority appear
at the top.

Personally I'd like a more granular 1-9 rather than High Medium Low and do agree
that it is confusng to the user as there is no visual distinction in the
priority column betweeen a Medium and None task.

HTH

Comment 2

[Joey Minta]

Reporter:
    This looks like an issue addressed in bug 204187.  Please look over that
bug, and if you agree that this is a duplicate, please resolve it as such.

Comment 3

[Robin Edrenius]

(In reply to comment #2)
> Reporter:
>     This looks like an issue addressed in bug 204187.  Please look over that
> bug, and if you agree that this is a duplicate, please resolve it as such.

What the reporter is talking about is that the tasks are sorted Low-Medium-High-None
This way it looks like the tasks with 'none' priority is the highest one. IMO
none should be removed and the default should be medium instead.

Comment 4

[Joey Minta]

Attachment: assume none=10 when sorting

A priority of 'none' is assigned the numerical value of 0, but a priority of
'high' is given 1.  This patch simply creates a dummy variable that changes 0
to 10 for the purposes of comparing tasks only.

Comment 5

[Joey Minta]

patch checked in.

Comment 6

[Paul Berendsen]

> Expected Results:  
> High, Medium, Low, None
> or 
> None, Low, Medium, High
> 
> (possibly place None in between Low and medium? and even replace "None" with
> "Normal")

I am pretty sure that order should be:
High - Medium - None - Low
or even
High - None - Medium - Low.

Rationale: None stands in general for:
priority rating for this event is (yet) undetermined.
There could be urgent/important events under "none".