speed up GetCacheElement by using hash table

VERIFIED FIXED in M14

Status

MailNews Core
Backend
P3
normal
VERIFIED FIXED
19 years ago
10 years ago

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Tracking

({perf})

Trunk
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [PDT+] ETA 02/16/00)

(Assignee)

Description

19 years ago
Currently, GetCacheElement iterates over an nsISupportsArray to find the 
matching cache entry. If you have a large number of folders, this can add up. I 
think there's a hash table version I can use instead.
(Assignee)

Comment 1

19 years ago
accepting, marking perf, thanks to Scott for finding this.
Status: NEW → ASSIGNED
Keywords: perf
Target Milestone: M14

Comment 2

19 years ago
nominating for Beta 1.  I have 169 folders(mail folders, newsgroups, and 
accounts).  I'm seeing in Quantify runs that this takes up about .56 seconds in 
mail startup on my machine.  Based on other performance numbers I think this 
would be about 2.5 to 4 seconds on a target machine.  I'd like to try to fix 
this.  If this gets accepted as a PDT+, I can take it from David since he's 
busy.
Keywords: beta1
(Assignee)

Comment 3

19 years ago
I would love to do this for beta1 - it shouldn't take very long. I should be 
able to get to it in the next week.

Comment 4

19 years ago
Putting on PDT+ radar for beta1.
Whiteboard: [PDT+]

Comment 5

19 years ago
I can probably do this one.  Just assign it back to yourself if you prefer.

Assignee: bienvenu → davidmc
Status: ASSIGNED → NEW
(Assignee)

Comment 6

19 years ago
I've already got a fix for this in my tree.
Assignee: davidmc → bienvenu
(Assignee)

Comment 7

19 years ago
I have a fix which I can checkin whenever I can get approval.
Status: NEW → ASSIGNED
Whiteboard: [PDT+] → [PDT+] ETA 02/16/00
(Assignee)

Comment 8

19 years ago
fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED

Comment 9

19 years ago
Par, can you verify?
QA Contact: lchiang → ppandit

Comment 10

19 years ago
Changes made in nsMsgFolderCache.cpp (v 1.21) reflect implementation of hash 
table.

MARK AS VERIFIED
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.