266642 - proposed checkins for CVS for ast-ES localization

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[xspuente]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ast-ES; rv:1.7) Gecko/20040616
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ast-ES; rv:1.7) Gecko/20040616

After smoketesting the win32 installer for Firefox 1.0RC1, a few accesskeys were
found to be not localized. Here I attached the following files to replace the
older ones in the CVS in order to correct those problems:

browser\locales\ast-ES\chrome\browser\bookmarks\bookmarks.properties
browser\locales\ast-ES\chrome\browser\pageInfo.dtd
browser\locales\ast-ES\chrome\browser\history\history.dtd
browser\locales\ast-ES\chrome\profile\bookmarks.html
toolkit\locales\ast-ES\chrome\global\customizeToolbar.dtd
toolkit\locales\ast-ES\chrome\global\editMenuOverlay.dtd
toolkit\locales\ast-ES\chrome\global\viewSource.dtd 

Reproducible: Always
Steps to Reproduce:
1. Not localized accesskeys
2. Should be localized
3. English access key appears between brackets

Comment 1

[xspuente]

Attachment: bookmarks.properties

new bookmarks.properties

Comment 2

[xspuente]

Attachment: pageInfo.dtd

New pageInfo.dtd ast-ES

Comment 3

[xspuente]

Attachment: history.dtd

New history.dtd ast-ES

Comment 4

[xspuente]

Attachment: bookmarks.html

New bookmarks.html ast-ES

Comment 5

[xspuente]

Attachment: customizeToolbar.dtd

New customizeToolbar.dtd ast-ES

Comment 6

[xspuente]

Attachment: editMenuOverlay.dtd

New editMenuOverlay.dtd ast-ES

Comment 7

[xspuente]

Attachment: viewSource.dtd

New viewSource.dtd ast-ES

Comment 8

[Benjamin Smedberg]

Next time, this should be a patch or a zip with just the changed files ;)

Comment 9

[xspuente]

Attachment: patches for ast-ES localization

I didn't see the proposed patches/files (sorry for that) landing on the ast-ES
cvs. I have attached two patches (correct format now), one for the browser
component, and the other for the toolkit. I hope they can be commited to cvs.
It solves bug 266043 (amazondotcom.src).

However, I fixed one file (bug 267500) but I cannot get a patch for it:

[xa@raguel]cvs diff chrome/mozapps/plugins/plugins.dtd >patch4
cvs diff: cannot open CVS/Entries for reading: No such file or directory
cvs [diff aborted]: no repository

I don't know how to commit the fixed file to cvs.

Comment 10

[xspuente]

OK, I was told how to commit the files and I think they definitly are. They were
the same they were approved, plus the chrome/mozapps/plugins/plugins.dtd that
covered bug 267500. I still don't see the changes in the lxr.mozilla.org, when
they appear I think the bug can be closed.