266660 - Add Extension: Open link in...

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Anton P.]

User-Agent:       Opera/7.54 (Windows ME; U)  [en]
Build Identifier: 

NAME: 
Open link in... 

TARGET: 
Fx 0.7 - 1.0+

DOWNLOAD: 
http://www.soton.ac.uk/~anton/software/openlink.xpi

FUNCTIONALITY: 
Adds items to the "right-click" context menu (CM) for links, images and 
background images in a webpage. These items are: 

When right-clicking a Link 
----------------------------- 
Items in the top-level of the CM: 
Open in Background Tab 
Open in Background Window 
Open (here, ie in the current tab/window) 

When right-clicking Images and Background Images 
------------------------------------------------------------ 
A new CM subfolder which provides: 
Open in Background Tab 
Open in New Tab 
Open in Background Window 
Open in New Window 

UI NOTES: 
1.) Open (here) is the default for images and bg images, and already has an item 
on the CM. I thought about whether to move that item into the submenu, but 
thought that probably that was the item that would be used most, and so didn't 
want to bury it away. I used submenus in order to avoid clutter on the CM 

2.) Open is the default for links, but doesn't have a CM item by default, so I 
added it. (Useful for forcing links which try to open in new windows to open in 
the current place.) I didn't put the new items in a submenu because I personally 
use them all the time, particulary Open in Background Tab. 

IMPLEMENTATION NOTES: 
1.) The functions which do the opening are pulled from browser.js and 
contentAreaUtils.js 

2.) Open in Background Window is not ideally implemented. It just opens a 
foreground window and then batters the original window with a second's-worth of 
focus() calls.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Fnord]

Tested ok.

UA: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107
Firefox/1.0

Two notes:

1) Background windows seem to only open in the foreground for me. Other stuff
works fine.

2) The maxVersion in install.rdf is "1.0+", I think some authors are getting
dinged for anything other that "1.0" but I don't know official policy.

Comment 2

[Anton P.]

Version numbering has been fixed:

TARGET:
Fx 0.9 - 1.0.
Also includes old install routine for Moz 1.x, Fx <0.9 but this is untested.

Functionality has been changed slightly:

* Open in New Tab honours the user's tab opening default as specified in
Tools -> Options | Advanced | Tabbed Browsing | Select new tabs opened from links.
Only one of 'Open in Background Tab', 'Open in Foreground Tab' appears,
according to the opposite of the user's default.

The context menu items are:

When right-clicking a Link
-----------------------------
Items in the top-level of the CM:
Open in Background Tab *
Open in Foreground Tab *
Open in Background Window
Open (here, ie in the current tab/window)

When right-clicking Images and Background Images
------------------------------------------------------------
A new CM subfolder which provides:
Open in Background Tab *
Open in Foreground Tab *
Open in New Tab *
Open in Background Window
Open in New Window


As for the Background Window opening in the foreground, this is caused by the
less-than-ideal implementation described in my first comment. Fnord, can you
describe in more detail what happens? Does it open first in the background and
then jump to the foreground? I'd love to fix this problem, but I've had no
responses on the MozillaZine forum as to how to open background windows "properly".

Comment 3

[alanjstr]

I have a feeling your description/changelog might be a little long.

Comment 4

[Anton P.]

Short description:

Adds context menu items for opening links and images in a new background tab 
(or foreground tab if your tabs normally open in the background), in a new 
background or foreground window, and in the current tab. Hence provides missing 
menu items for some funtions already available via keystrokes.

Comment 5

[Anton P.]

Actually, scrap that last sentence and just go with the first one.

Comment 6

[alanjstr]

The queue has been approved.  Please be sure to clear the status whiteboard when
you reopen a bug.  Thanks.

Comment 7

[alanjstr]

Description updated

Comment 8

[Anton P.]

update.mozilla.org administrators:

Could you put this extension in Tabbed Browsing category rather than---or, if
the database allows, in addition to---Miscellaneous. Although the extension has
a variety of features, its primary purpose is the tabbed browsing ones (Open in
New Background/Foreground Tab). [The Tabbed Browsing category was where I
originally looked when I first searched for an extension like this!]

Comment 9

[Anton P.]

update.mozilla.org administrators:

Could you put this extension in Tabbed Browsing category rather than---or, if
the database allows, in addition to---Miscellaneous. Although the extension has
a variety of features, its primary purpose is the tabbed browsing ones (Open in
New Background/Foreground Tab). [The Tabbed Browsing category was where I
originally looked when I first searched for an extension like this!]. Thanks

Comment 10

[Michael Hendy (Hendikins)]

Bulk Moving Extension/Theme listing bugs to new component.
(Filter: masslistingspam)

Comment 11

[alanjstr]

Category changed

Comment 12

[Anton P.]

Extension has been updated to version 1.2, which changes the menu text slightly
from "Open" to "Open Link Here", and also fixes a bug in the "Open Link in
Background Window" feature which had slipped in to version 1.1 and which
prevented the feature from working.

u.m.o administrators: please could you update this extension; the original link
I provided now holds the new version.

Comment 13

[alanjstr]

Forbidden
You don't have permission to access /~anton/software/openlink.xpi on this server.

Comment 14

[Anton P.]

Apologies. It should work now.

Comment 15

[Anton P.]

update.mozilla.org administrators: please could you change the author name to
"Anton Prowse". Also, I'd be grateful if you would upload the new version (1.2)
onto the site. Many thanks.

Comment 16

[Anton P.]

This extension has been upgraded again, to version 1.3. The original link
provided now points to this upgrade.

u.m.o administrators: please could you add this note to the comment for this
extension:

"Users should uninstall any version prior to 1.3 before installing version 1.3
or higher."

Thanks.

Comment 17

[alanjstr]

Why did you change the GUID from {openlink-0fa3-4886-8adf-24a3e6301ec5} to
{ff81e780-5cc0-11d9-9669-0800200c9a66}

Was it to use a legit GUID instead of a made up one?

Comment 18

[Anton P.]

Yes, despite my strong disapproval of extension folders which do not have at
least some human-readable part (not least because using a GUID does nothing to
ensure uniqueness in the chrome system), I have opted to provide my extension
with a legal GUID following discussions at
http://forums.mozillazine.org/viewtopic.php?t=157579&postdays=0&postorder=asc&postsperpage=15&start=0

Comment 19

[alanjstr]

To be approved tonight.

Comment 20

[Michael Morgan [:morgamic]]

AMO BUGSPAM FOR COMPONENT MOVE AND DELETE (FILTER ME)