266725 - When doing an online search for IMAP, we should skip any virtual folders

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

Otherwise you get errors about the folder not being subscribed to.

I don't know if we can easily hide the VF from the list of folders that can be
searched or not. But maybe we can make the code internally skip any virtual
folders when building the list of folders to search.

Comment 1

[Scott MacGregor]

Actually it looks like we the advanced search dialog is already ommitting
virtual folders when searching.

I was getting this error because I had a deleted VF in my trash folder which for
some reason has lost its virtual folder state. I'm not sure why. 

In any case, I can still hide the virtual folders from the search dialog UI, the
virtual folder picker dialog and anywhere else we show folder lists where we
should be omitting virtual folders...

Comment 2

[Scott MacGregor]

Attachment: the fix

Comment 3

[Scott MacGregor]

Comment on attachment 163884 [details] [diff] [review]
the fix

This does the following:

1) Hides virtual folders from the advanced search dialog folder picker

2) Hides virtual folders from the virtual folder list folder picker dialog.
3) If you select a virtual folder and then bring up the advanced search dialog,
we won't preselect the VF, we'll fall back to the account.


Are there any other spots in the UI where we should be hiding virtual folders?
I didn't see any. I thought about filters (move / copy destination) but it
looks like we are already doing the right thing there.

Comment 4

[Scott MacGregor]

fixed branch and trunk