266829 - thunderbird cvs fails to compile owing to lack of nsICmdLineService.h

Status: VERIFIED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mitch]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20041027
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20041027

This is possibly due to the effects of bug 237745 that was checked in yesterday.

CVS compile failure as follows:

make[5]: Entering directory `/usr/src/moz/mozilla/mail/components/gnome'
nsMailGNOMEIntegration.cpp
g++ -o nsMailGNOMEIntegration.o -c -DOSTYPE=\"Linux2.6\" -DOSARCH=\"Linux\" 
-I../../../dist/include/xpcom -I../../../dist/include/string
-I../../../dist/include/mozgnome -I../../../dist/include/msgbase
-I../../../dist/include/appshell -I../../../dist/include/intl
-I../../../dist/include/windowwatcher -I../../../dist/include/pref
-I../../../dist/include/mail_gnome -I../../../dist/include
-I/usr/src/moz/mozilla/dist/include/nspr     -I/usr/X11R6/include   -fPIC 
-I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion
-Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy
-Wno-non-virtual-dtor -Wno-long-long -pedantic -I/usr/local/include
-fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -Os
-I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include
-I/usr/local/include/pango-1.0 -I/usr/X11R6/include -I/usr/local/include
-I/usr/local/include/freetype2 -I/usr/local/include/gtk-2.0
-I/usr/local/include/atk-1.0 -I/usr/local/lib/gtk-2.0/include   
-I/usr/X11R6/include -DMOZILLA_CLIENT -include ../../../mozilla-config.h
-Wp,-MD,.deps/nsMailGNOMEIntegration.pp nsMailGNOMEIntegration.cpp
nsMailGNOMEIntegration.cpp:45:31: nsICmdLineService.h: No such file or
directorynsMailGNOMEIntegration.cpp: In member function `nsresult
nsMailGNOMEIntegration::Init()':
nsMailGNOMEIntegration.cpp:80: error: `nsICmdLineService' undeclared (first use
this function)
nsMailGNOMEIntegration.cpp:80: error: (Each undeclared identifier is reported
only once for each function it appears in.)
nsMailGNOMEIntegration.cpp:80: error: template argument 1 is invalid
nsMailGNOMEIntegration.cpp:80: error: invalid type in declaration before '=' token
nsMailGNOMEIntegration.cpp:81: error: cannot convert `const
nsGetServiceByContractID' to `int' in initialization
nsMailGNOMEIntegration.cpp:86: error: base operand of `->' is not a pointer
make[5]: *** [nsMailGNOMEIntegration.o] Error 1
make[5]: Leaving directory `/usr/src/moz/mozilla/mail/components/gnome'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/usr/src/moz/mozilla/mail/components'
make[3]: *** [libs] Error 2
make[3]: Leaving directory `/usr/src/moz/mozilla/mail'
make[2]: *** [tier_99] Error 2
make[2]: Leaving directory `/usr/src/moz/mozilla'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/usr/src/moz/mozilla'
make: *** [build] Error 2


Reproducible: Always
Steps to Reproduce:
1. build thunderbird from cvs
2.
3.

Comment 1

[Calum Mackay]

Ironically I get a similar, but different failure, resulting from the same
missing header:

c++ -o nsChromeProtocolHandler.o -c -DOSTYPE=\"Linux2.6\" -DOSARCH=\"Linux\"
-DHAVE_DEPENDENT_LIBS  -I../../dist/include/xpcom -I../../dist/include/string
-I../../dist/include/rdf -I../../dist/include/content -
I../../dist/include/xuldoc -I../../dist/include/gfx -I../../dist/include/layout
-I../../dist/include/content -I../../dist/include/locale
-I../../dist/include/necko -I../../dist/include/dom -I../../dist/include/
widget -I../../dist/include/js -I../../dist/include/appshell
-I../../dist/include/appstartup -I../../dist/include/appcomps
-I../../dist/include/caps -I../../dist/include/pref
-I../../dist/include/docshell -I../
../dist/include/xpconnect -I../../dist/include/jar -I../../dist/include/chrome
-I../../dist/include -I/usr/local/src/mozilla/cvs/mozilla/dist/include/nspr    
-I. -I/usr/local/X11R6/include   -fPIC  -I/usr/loca
l/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith
-Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy
-Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthrea
d -pipe  -DNDEBUG -DTRIMMED -O2 -march=i686  -I/usr/local/X11R6/include
-DMOZILLA_CLIENT -include ../../mozilla-config.h
-Wp,-MD,.deps/nsChromeProtocolHandler.pp nsChromeProtocolHandler.cpp
nsChromeRegistry.cpp:100:31: nsICmdLineService.h: No such file or directory
nsChromeRegistry.cpp: In member function `nsresult nsChromeRegistry::Init()':
nsChromeRegistry.cpp:306: error: `nsICmdLineService' undeclared (first use this 
   function)
nsChromeRegistry.cpp:306: error: (Each undeclared identifier is reported only 
   once for each function it appears in.)
nsChromeRegistry.cpp:306: error: template argument 1 is invalid
nsChromeRegistry.cpp:307: error: ISO C++ forbids declaration of `cmdLineArgs' 
   with no type
nsChromeRegistry.cpp:307: error: cannot convert `const nsGetServiceByContractID
   ' to `int' in initialization
nsChromeRegistry.cpp:310: error: base operand of `->' is not a pointer
make[4]: *** [nsChromeRegistry.o] Error 1
make[4]: Leaving directory `/usr/local/src/mozilla/cvs/mozilla/chrome/src'

Comment 2

[Scott MacGregor]

benjamin, is this fall out from 237745?

Comment 3

[Benjamin Smedberg]

Fixes went in last night. I fixed a separate windows-only bustage in
windowshooks this morning.

Comment 4

[David :Bienvenu]

my windows build is still broken for two reasons:

I needed to add 

LOCAL_INCLUDES +=  -I$(topsrcdir)/xpfe/bootstrap 

to xpfe/components/winhooks/Makefile.in so that it could find a header file in
xpfe/bootstrap.

and then nsWindowsHooksUtil.cpp doesn't compile because IDS_STARTMENU_APPNAME is
not defined.

Comment 5

[David G King]

(In reply to comment #4)

> and then nsWindowsHooksUtil.cpp doesn't compile because IDS_STARTMENU_APPNAME is
> not defined.

This problem is what is causing the WINNT tinderbox (patrocles) to burn.

Comment 6

[Mitch]

Confirm fix on Linux. Just built tbird from cvs.

Comment 7

[Calum Mackay]

yup, me too.