266831 - Current download should have focus in download manager

Status: RESOLVED FIXED

(Camino Graveyard :: Downloading, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a5) Gecko/20041029 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a5) Gecko/20041029 Camino/0.8+

When a download or downloads begin, no download is selected, making all of the
download manager buttons inoperative without an additional click.  The currently
active download (or, in the case of multiple active downloads, the last one to
be added to the download manager) should be selected so that the buttons can be
active without additional clicks.

(Safari and Firefox actually have their "buttons" attached to the download
itself, so all downloads can be acted upon with a single click.  If the download
manager is ever up for a major redesign, their way might be a better way to go
about this)

Reproducible: Always
Steps to Reproduce:
1. Clear all downloads if any have previously been selected.
1. Click on a link to a downloadable file type.
2. Attempt to press a toolbar button to act upon the download.

Actual Results:  
Toolbar buttons greyed out because no download was selected.

Expected Results:  
Most-recently added download should be selected so that toolbar buttons are
active for that download without requiring additional clicks first.

Comment 1

[Bruce Davidson]

Confirming this.

Having read this bug report it seems bizarre to me that its not what we've
always done!

Comment 2

[Josh Aas]

Basically we just need to make sure that if any downloads exist, at least one is
selected at all times. I can fix this pretty easily, so marking 0.9.

Comment 3

[Josh Aas]

Attachment: fix and function name cleanup v1.0

Comment 4

[Josh Aas]

Comment on attachment 167724 [details] [diff] [review]
fix and function name cleanup v1.0

This is a pretty trivial fix.

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 167724 [details] [diff] [review]
fix and function name cleanup v1.0

sr=pink

Comment 6

[Josh Aas]

landed on trunk