266839 - Opera pref. migration code treats UTF-8 as 'ASCII'

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[Jungshik Shin]

This is similar to bug 246403. SetWString  uses 'AssignWithConversion' thta
inflates each byte in C strings to a 16-bit PRUnichar. SetFile also assumes that
'paths' in the opera pref. file is in the native file system encoding when it's
actully in UTF-8. 
 
A patch coming up.

Comment 1

[Jungshik Shin]

Attachment: patch

fixes SetWString and SetFile

Comment 2

[Jungshik Shin]

Comment on attachment 163948 [details] [diff] [review]
patch

asking for r/sr

Comment 3

[Jungshik Shin]

Comment on attachment 163948 [details] [diff] [review]
patch

SetFile() may not work until bug 256410 is properly fixed.

SetWString should just work as it is.

Comment 4

[Jungshik Shin]

Comment on attachment 163948 [details] [diff] [review]
patch

Asking for r/sr.

The problem in the previous comment has been sorta resolved.(or was not much a issue in the first place).

Comment 5

[Jungshik Shin]

Attachment: patch updated to the trunk

the trunk replaced 'AssignWithConversion' with 'NS_ConvertASCIItoUTF16', which is still wrong. I replaced it with 'NS_ConvertUTF8toUTF16' as in my previous patch. This was well tested back in September. 

Mike, pls take a moment to review it. 
Carrying over darin's sr because the patch is virtually identical.

Comment 6

[Jungshik Shin]

Comment on attachment 250130 [details] [diff] [review]
patch updated to the trunk

sorry for bug spam. i don't like bugzilla's new behavior of not prompting to pick one among multiple matches....

Comment 7

[Mats Palmgren (inactive)]

This was checked in 2007-01-06
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp&rev=1.71&root=/cvsroot&mark=344,375#339

-> FIXED