Closed Bug 26686 Opened 25 years ago Closed 25 years ago

crash in nsHTTPRequest::~nsHTTPRequest()

Categories

(Core :: Networking, defect, P3)

Product:
Core
Component:
Networking
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
CLOSED DUPLICATE of bug 21556

People

(Reporter: patrick, Assigned: gagan)

References

(
URL
)

Details

(Whiteboard: [PDT+] ETA 02/22/00) 

My system is linux 2.2.12, with glibc version 2.1.2
I installed:
mozilla-i686-pc-linux-gnu-M13-fullcircle
It is so unstable that it is basically unusable. It will crash without fail
within 2-3 minutes of me loading the application. The url I am broswing does not
seem to mak eany difference.
Here is a lising of my last three attempt to run M13, not that on the second
attempt it crashes straight away!
I seems to me that this build hasn't even been remotely tested on a linux
system!

[pim@patrick package]$ ./run-mozilla.sh 
MOZILLA_FIVE_HOME=/home/pim/temp/package
  LD_LIBRARY_PATH=/home/pim/temp/package
       SHLIB_PATH=/home/pim/temp/package
          LIBPATH=/home/pim/temp/package
      MOZ_PROGRAM=mozilla-bin
      MOZ_TOOLKIT=
        moz_debug=0
     moz_debugger=
nNCL: registering deferred (0)
WEBSHELL+ = 1
 I am inside the initialize
 Hey : You are in QFA Startup 
(QFA)Talkback loaded Ok.
WEBSHELL+ = 2
failed to get the xpfe.dragdrop.enable pref, assuming it is off
nsXULKeyListenerImpl::Init()
nsCollationUnix::Initialize mLocale = C
nsCollationUnix::Initialize mCharset = ISO-8859-1
WEBSHELL+ = 3
WEBSHELL+ = 4
title string = [Mozilla]
title string = [Mozilla - Mozilla]
Setting content window
browser.startup.page = 1
startpage = http://www.mozilla.org/projects/seamonkey/release-notes/m13.html
got a request
title string = [M13 Release Notes - Mozilla]
Document http://www.mozilla.org/projects/seamonkey/release-notes/m13.html loaded
 successfully
Document: Done (9.371 secs)
WEBSHELL+ = 5
FindShortcut: in='http://www.topcelebritypages.com/'  out='null'
title string = [Celebrity pages directory - Mozilla]
nsLayoutHistoryState::GetState, ERROR getting History state for the key
Document http://www.topcelebritypages.com/ loaded successfully
Document: Done (5.411 secs)
[pim@patrick package]$ ./run-mozilla.sh 
MOZILLA_FIVE_HOME=/home/pim/temp/package
  LD_LIBRARY_PATH=/home/pim/temp/package
       SHLIB_PATH=/home/pim/temp/package
          LIBPATH=/home/pim/temp/package
      MOZ_PROGRAM=mozilla-bin
      MOZ_TOOLKIT=
        moz_debug=0
     moz_debugger=
nNCL: registering deferred (0)
WEBSHELL+ = 1
 I am inside the initialize
 Hey : You are in QFA Startup 
(QFA)Talkback loaded Ok.
WEBSHELL+ = 2




[pim@patrick package]$ ./run-mozilla.sh 
MOZILLA_FIVE_HOME=/home/pim/temp/package
  LD_LIBRARY_PATH=/home/pim/temp/package
       SHLIB_PATH=/home/pim/temp/package
          LIBPATH=/home/pim/temp/package
      MOZ_PROGRAM=mozilla-bin
      MOZ_TOOLKIT=
        moz_debug=0
     moz_debugger=
nNCL: registering deferred (0)
WEBSHELL+ = 1
 I am inside the initialize
 Hey : You are in QFA Startup 
(QFA)Talkback loaded Ok.
WEBSHELL+ = 2
failed to get the xpfe.dragdrop.enable pref, assuming it is off
nsXULKeyListenerImpl::Init()
nsCollationUnix::Initialize mLocale = C
nsCollationUnix::Initialize mCharset = ISO-8859-1
WEBSHELL+ = 3
WEBSHELL+ = 4
title string = [Mozilla]
Setting content window
browser.startup.page = 1
startpage = http://www.mozilla.org/projects/seamonkey/release-notes/m13.html
title string = [Mozilla - Mozilla]
got a request
title string = [M13 Release Notes - Mozilla]
Document http://www.mozilla.org/projects/seamonkey/release-notes/m13.html loaded
successfully
Document: Done (7.263 secs)
WEBSHELL+ = 5
FindShortcut: in='www.topcelebritypages.com'  out='null'
title string = [Celebrity pages directory - Mozilla]
nsLayoutHistoryState::GetState, ERROR getting History state for the key
Document http://www.topcelebritypages.com/ loaded successfully
Document: Done (9.241 secs)
title string = [Celebrity pages directory - Mozilla]
nsLayoutHistoryState::GetState, ERROR getting History state for the key
Error loading URL http://www.topcelebritypages.com/ 
Document: Done (29.546 secs)
title string = [Anna Kournikova links - Mozilla]
Document http://www.topcelebritypages.com/l/Anna_Kournikova.html loaded
successfully
Document: Done (22.89 secs)
title string = [Anna Kournikova ring - Mozilla]
WEBSHELL+ = 6
failed to get the xpfe.dragdrop.enable pref, assuming it is off
nsXULKeyListenerImpl::Init()
WEBSHELL+ = 7
WEBSHELL+ = 8
title string = [Mozilla]
Setting content window
browser.startup.page = 1
startpage = http://www.mozilla.org/projects/seamonkey/release-notes/m13.html
got a request
title string = [Mozilla - Mozilla]
WEBSHELL+ = 9
WEBSHELL+ = 10
title string = [Anna Kournikova's Palace - Mozilla]
Document
http://www.topcelebritypages.com/cgi-bin/m/LinkFrame1.pl?id=6&pos=1&nm=Anna%20Kournikova
loaded successfully
Document: Done (32.451 secs)
Document
http://www.topcelebritypages.com/cgi-bin/m/LinkOut1.pl?id=6&pos=1&nm=Anna%20Kournikova
loaded successfully
Document: Done (37.241 secs)
This is a bit generic.  Could you state what Linux you use (Redhat, etc.).
Also, check bug 8849, which is similar.

patrick@spacesurfer.com has sent us four talkback reports.  will look this over.

cbegle - could you assign the bug to yourself then? Or can I accept this bug?

Thanks

patrick@spacesurfer.com:

Three of your crashes were the same thing.  stack trace is below.  if you are 
still able to reproduce the problem, please add the steps to reproduce in this 
bug.  

For future reference, the kind of information we need in a bug report, is here:
     http://www.mozilla.org/quality/bug-writing-guidelines.html
If you crash, a stack trace is also useful.  The console output is not always 
the most useful information.

Providing this information helps us pin down the problem without us having to 
go back and forth a bunch of times, which takes a lot of time and energy.

I appreciate your participation, but we need whatever information you can 
provide so we can reproduce this bug.


   nsHTTPRequest::~nsHTTPRequest() 
   nsHTTPRequest::Release() 
   nsHTTPChannel::~nsHTTPChannel() 
   nsHTTPChannel::Release() 
   nsStreamListenerEvent::~nsStreamListenerEvent() 
   nsOnStopRequestEvent::~nsOnStopRequestEvent() 
   nsStreamListenerEvent::DestroyPLEvent() 
   libplds3.so + 0x1c6d (0x4012dc6d) 
   libplds3.so + 0x1c46 (0x4012dc46) 
   libplds3.so + 0x1b86 (0x4012db86) 
   nsEventQueueImpl::ProcessPendingEvents() 
   event_processor_callback() 
   our_gdk_io_invoke() 
   libglib-1.2.so.0 + 0xe52a (0x407b152a) 
   libglib-1.2.so.0 + 0xfbe6 (0x407b2be6) 
   libglib-1.2.so.0 + 0x101a1 (0x407b31a1) 
   libglib-1.2.so.0 + 0x10341 (0x407b3341) 
   libgtk-1.2.so.0 + 0x8c209 (0x406dd209) 
   nsAppShell::Run() 
   nsAppShellService::Run() 
   main1() 
   main() 
   libc.so.6 + 0x181eb (0x402171eb)
Summary: M13 Extremely unstable → crash in nsHTTPRequest::~nsHTTPRequest()
reassigning to networking.  patrick@spacesurfer.org: please add steps on how to 
reproduce this bug.
Assignee: leger → gagan
Component: Browser-General → Networking
QA Contact: cbegle → tever
User says things are unusable for him. Marking beta1.
Keywords: beta1
Target Milestone: M14
Putting on PDT+ radar for beta1.
Whiteboard: [PDT+]
my changes to the bug 24642 should remove the crash (NS_RELEASE to
NS_IF_RELEASE)
Status: NEW → ASSIGNED
Whiteboard: [PDT+] → [PDT+] ETA 02/22/00
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Arrrrrg!!  Changing the NS_RELEASE(...) to an NS_IF_RELEASE(...) does *not* seem 
like a good fix.  IT will only make it *harder* to find the underlying 
instability in the system.

As far as I can see there are two possibilities:
1. There is a fundamental ownership problem in HTTP.  Since the rest of the code 
does not check before dereferencing the pointer, we still have a potential 
crash.  Unfortunately, this one wil be less frequent and thus harder to track 
down.

2. This is *really* a dup of bug #21556 and is a symptom of a lack of 
thread-safety within the system.

In either case, changing the NS_RELEASE() to NS_IF_RELEASE() will only make it 
*harder* to find the REAL bug!!!
Discussed this with rpotts.   This is probably a dupe and should be fixed when 
21556 is addressed.    Re-opening to mark as dupe.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

*** This bug has been marked as a duplicate of 21556 ***
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → DUPLICATE
closing
Status: RESOLVED → CLOSED
You need to log in before you can comment on or make changes to this bug.