Closed
Bug 266875
Opened 20 years ago
Closed 20 years ago
Non-standard keys: Export key is accel+O, Open has no shortcut
Categories
(Calendar :: Sunbird Only, defect)
Calendar
Sunbird Only
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mattwillis, Assigned: mattwillis)
Details
Attachments
(1 file, 1 obsolete file)
|
88.23 KB,
patch
|
mostafah
:
first-review+
|
Details | Diff | Splinter Review |
Open historically has the shortcut key of accel+O. Export now has that shortcut. Open should have accel+O, and Export should either get a new key, or have the shortcut omitted. Note that this is the SHORTCUT key, NOT the underlined character used for keyboard (Alt F...) navigation.
| Assignee | ||
Comment 1•20 years ago
|
||
This patch adds accel+O as the Open shortcut key, and removes the Export shortcut key altogether. This includes references to it in the .inc files, as well as the .dtds. The patch also changes DOS to UNIX linebreaks on a couple of the DTDs.
| Assignee | ||
Updated•20 years ago
|
Attachment #163976 -
Flags: first-review?(mostafah)
| Assignee | ||
Updated•20 years ago
|
Attachment #163976 -
Flags: first-review?(mostafah)
| Assignee | ||
Comment 2•20 years ago
|
||
Revised the patch to also replace the crazy, hard for vi/emacs to parse, ellipse characters with "..."
| Assignee | ||
Updated•20 years ago
|
Attachment #163976 -
Attachment is obsolete: true
| Assignee | ||
Updated•20 years ago
|
Attachment #163978 -
Flags: first-review?(mostafah)
Edit the files with a modern editor that can handle utf-8. Gnu Emacs can handle european utf-8, including the ellipsis character, if you set (custom-set-variables '(current-language-environment "UTF-8")) This also important because utf-8 sometimes encodes a character using multiple bytes, and sometimes one of the bytes looks like a hard space character (0xA0) leading someone to erroneously delete it.
Comment 4•20 years ago
|
||
Comment on attachment 163978 [details] [diff] [review] rev1 - trunk - patch also removes crazy ellipse characters for standard "..." The (...) character is preferred. Please undo that change and resubmit.
Attachment #163978 -
Flags: first-review?(mostafah) → first-review-
| Assignee | ||
Comment 5•20 years ago
|
||
In that case, take rev0, as the only change between the two files was the ellipse replacement.
| Assignee | ||
Updated•20 years ago
|
Attachment #163976 -
Attachment is obsolete: false
Attachment #163976 -
Flags: first-review?(mostafah)
| Assignee | ||
Updated•20 years ago
|
Attachment #163978 -
Attachment is obsolete: true
Updated•20 years ago
|
Attachment #163976 -
Flags: first-review?(mostafah) → first-review+
Comment 6•20 years ago
|
||
Fixed in CVS. Thanks
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 7•18 years ago
|
||
The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!
QA Contact: gurganbl → sunbird
You need to log in
before you can comment on or make changes to this bug.
Description
•