266890 - Remove nsListboxScrollPortFrame

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

One of my ongoing projects is to eliminate nsScrollBoxFrame and make the
scrolled frame be a direct child of nsGfxScrollFrame. This requires that
nsScrollPortFrame and nsListboxScrollPortFrame also be eliminated since they
descend from nsScrollBoxFrame. I will attach a patch that gets rid of
nsListboxScrollPortFrame by moving its functionality into nsListBoxBodyFrame and
adding a new nsIFrame API, GetMinSizeForScrollArea so it can make
nsScrollBoxFrame do the right thing.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix as described

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Checked in.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: followup: remove nsScrollPortFrame

Now I'm removing nsScrollPortFrame. Things to note:
-- nsScrollPortFrame is the only subclass of nsScrollBoxFrame
-- We never create nsScrollBoxFrame directly, only nsScrollPortFrames
-- All nsScrollPortFrame does is override NeedsWidget

So I move the NeedsWidget implementation up to nsScrollBoxFrame, convert all
creators of nsScrollPortFrame to nsScrollBoxFrame and remove nsScrollPortFrame.
In addition to this patch I'll be cvs removing nsScrollPortFrame.h and
nsScrollPortFrame.cpp.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 5

[[e-mail]]

Comment on attachment 164681 [details] [diff] [review]
followup: remove nsScrollPortFrame

>+    nsIFormControlFrame* fcFrame;
>+    if ((NS_SUCCEEDED(parentFrame->QueryInterface(NS_GET_IID(nsIFormControlFrame), (void**)&fcFrame)))) {
Just wondering... aren't you supposed to use NS_REINTERPRET_CAST here?
Or alternatively declare void* fcFrame; Or use CallQueryInterface? Or?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah but I'm just moving old code