266904 - Discovered feeds aren't cleared on loads in background tabs (refresh or drag and drop)

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Riku Nurminen]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20041001 Firefox/0.10.1

XML feeds that are defined in <link> tags and show up in the Firefox RSS button
menu in the bottom-right corner ("Subscribe to '..' ") keep adding up to produce
infinite duplicates when a page is set to refresh with <meta> tags AND the
meta-refreshing tab is not selected. When the tab is reloaded by hand OR
selected and refreshed by the meta-refresh, the list gets cleared correctly.

Reproducible: Always
Steps to Reproduce:
1. Start firefox, open two tabs
2. In other tab go to http://www.rakkis.net/firefox-rssbutton-metareload-bug.html
3. Select any other tab
4. Wait 20 seconds.
5. Select the tab in which the first link was opened; you can now see that the
two RSS feeds defined in the site appear multiple times when you click on the
small RSS button to bring up the "Subscribe to '..' " menu. When you refresh the
page by hand, or wait another 10 seconds when the page is selected, the menu
gets cleared up correctly and only 2 feeds show up.
Actual Results:  
Multiple (duplicate) items of the two RSS feeds defined in the page HTML appear
in the RSS button menu.

Expected Results:  
The RSS button menu should clear every time the page is reloaded, so that only
two RSS feeds (as defined by the HTML) appear always there.

Comment 1

[Riku Nurminen]

I now noticed that the same duplication happens if you right click on another
tab that has RSS feeds and click on "Reload tab", so that the tab gets reloaded
when it's not selected.

Comment 2

[Phil Ringnalda (:philor)]

Or if you drag a link and drop it on a background tab: it's the same bug in any situation that loads a page in a tab in the background, because startDocumentLoad isn't called, and that's where the list of discovered feeds gets cleared.

Comment 3

[Phil Ringnalda (:philor)]

*** Bug 288128 has been marked as a duplicate of this bug. ***

Comment 4

[Phil Ringnalda (:philor)]

*** Bug 304636 has been marked as a duplicate of this bug. ***

Comment 5

[Phil Ringnalda (:philor)]

*** Bug 281870 has been marked as a duplicate of this bug. ***

Comment 6

[Phil Ringnalda (:philor)]

*** Bug 357072 has been marked as a duplicate of this bug. ***

Comment 7

[Robert Sayre]

Attachment: listen for unload

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 248117 [details] [diff] [review]
listen for unload

>Index: browser.js

>+    gBrowser.addEventListener("unload", FeedHandler.onUnloadContent, true);

You should use the "pagehide" event rather than "unload", otherwise this will still occur for background session history navigation (content-triggered history.back(), for example) when fastback is enabled.

r=me with that change.

Comment 9

[Robert Sayre]

Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.745; previous revision: 1.744
done

Comment 10

[Robert Sayre]

Attachment: patch w/ gavin's comments

Comment 11

[Robert Sayre]

requesting blocking 1.8.1.1 (or 1.8.1.2) -- landing bug 344022 on the branch without landing this bug caused a pretty major regression, where the feed icon isn't removed from the feed preview page.

Comment 12

[Robert Sayre]

(In reply to comment #11)
> requesting blocking 1.8.1.1 (or 1.8.1.2) -- landing bug 344022 on the branch
> without landing this bug 

er, landing bug 347897 without landing this bug caused the regression

Comment 13

[Jay Patel [:jay]]

Comment on attachment 248402 [details] [diff] [review]
patch w/ gavin's comments

Approved for 1.8 branch, a=jay for drivers.

Comment 14

[Robert Sayre]

Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.479.2.214; previous revision: 1.479.2.213
done

Comment 15

[alice nodelman [:alice] [:anode]]

verified existence of bug in 2.0.0.1 (1.8.1.1) by opening two tabs.  Opened news.yahoo.com in one tab.  Dragged it to the other tab.  Dragged it to the other tab again.  Clicked to other tab - saw duplicate rss entries.

rss icon entries are not duplicated in 2.0.0.2pre.

verified fixed
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2pre) Gecko/2007011103 BonEcho/2.0.0.2pre