Closed
Bug 266930
Opened 20 years ago
Closed 19 years ago
ua.css should now be installed (symlinked) rather than copied
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file, 1 obsolete file)
1.10 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
On 2000/07/31 cls checked in a patch to copy ua.css in case MathML changed it; bz claims that this is no longer necessary.
Assignee | ||
Comment 1•20 years ago
|
||
Assignee: nobody → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Attachment #164017 -
Flags: superreview?(rbs)
Attachment #164017 -
Flags: review?(bzbarsky)
Comment 2•20 years ago
|
||
Neil, I don't really know build system stuff well enough to review it..
Assignee | ||
Updated•20 years ago
|
Attachment #164017 -
Flags: review?(bzbarsky) → review?(bsmedberg)
Comment on attachment 164017 [details] [diff] [review] Proposed patch I am not sure of the benefit either.
Attachment #164017 -
Flags: superreview?(rbs)
The benefit is not having to remember to build in some random directory for ua.css (when other similar files don't require any rebuild).
Updated•20 years ago
|
Attachment #164017 -
Flags: review?(bsmedberg) → review+
Assignee | ||
Updated•20 years ago
|
Attachment #164017 -
Flags: superreview?(dbaron)
Comment on attachment 164017 [details] [diff] [review] Proposed patch As long as this properly overwrites the copied file with the symlink when doing a depend build that picked up the change, sr=dbaron.
Attachment #164017 -
Flags: superreview?(dbaron) → superreview+
Assignee | ||
Comment 6•20 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
FWIW, it looks like SVG modifies the ua.css in dist, which leads to modifications of what's in the tree, so we really weren't quite ready for this.
Comment 8•20 years ago
|
||
Sounds like we should put the SVG import inside a preprocessor directive and preprocess ua.css, then....
I backed this out because of the SVG thing -- we don't want people accidentally checking that in because their srcdir was tainted. But this would still be good to do once SVG is fixed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(I think we really want to make SVG work like MathML, no?)
Comment 11•20 years ago
|
||
Yes; that's why we have the catalog sheets stuff...
Comment 12•19 years ago
|
||
SVG has been fixed so that it no longer munges ua.css.
Assignee | ||
Comment 13•19 years ago
|
||
Attachment #164017 -
Attachment is obsolete: true
Attachment #178581 -
Flags: review?(benjamin)
Attachment #178581 -
Flags: superreview+
Attachment #178581 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 14•19 years ago
|
||
Fix checked back in :-)
Status: REOPENED → RESOLVED
Closed: 20 years ago → 19 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•