266965 - extension not installed and stucked in manager

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Ivan Ičin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1

cuneAform extension does not function after browser restart, and it is stucked
in the Extension manager as 'This item will be uninstalled after you restart
Firefox', and restarting of FF has no effect.

Reproducible on clean profile

Reproducible: Always
Steps to Reproduce:
1. install extension: http://download.mozdev.org/cuneaform/cuneAform.xpi
2. restart browser
3. Look in Tools/Extensions

Actual Results:  
There is a text under extension name 'This item will be uninstalled after you
restart Firefox'. It is stucked there no matter how many times you restart Firefox.

Expected Results:  
Extension works normally, or at least I can uninstall it.

It seems that this influences some other installed extensions to refuse to obey
on commands from extension manager (they countinue to work with text that they
will be installed next time, but restart doesn't help)

Comment 1

[Nickolay_Ponomarev]

confirmed (winxp/rc1, clean profile).

I see the following info in console:
(exception in) nsEM::_finishOperations: "Cannot modify properties of a
WrappedNative" (NS_ERROR_XPC_CANNOT_MODIFY_PROP_ON_WN)
location: nsEM.js :: nsExtensionInstaller_install :: line 957

The problem with the extension is that the jar file is badly named
(chrome/chrome.jar instead of chrome/cuneAform.jar as declared in install.rdf).

That makes EM choke on "!aFile.isDirectory()" check in
nsExtensionInstaller__registerChrome, since aFile does not exist. That throws a
(NS_ERROR_FILE_NOT_FOUND) exception.

It is caught in nsExtensionInstaller_install but then the exception handler
fails itself on this line:
>e.extensionID = this._extensionID;

Which is unexpected exception, and Firefox doesn't show the error message and
doesn't uninstall the ext. on next run.

CCing Torisugari who is responsible, I think, for !aFile.isDirectory() code.

I think "e.extensionID = this._extensionID;" should be removed (ie. replaced
with something else) so that future exceptions that don't allow their props
changing don't cause bugs like this.

Comment 2

[O. Atsushi (Torisugari)]

(In reply to comment #1)
> CCing Torisugari who is responsible, I think, for !aFile.isDirectory() code.
I am? nope.
https://bugzilla.mozilla.org/attachment.cgi?id=155682&action=diff

> I think "e.extensionID = this._extensionID;" should be removed (ie. replaced
> with something else) so that future exceptions that don't allow their props
> changing don't cause bugs like this.

Something like
if("extensionID" in e)
  ...
else
  ...


,and this bug IS

Installer doesn't throw proper error,
when the file specified in install.rdf does not exists
(e.g. file path typo).


?

Comment 3

[O. Atsushi (Torisugari)]

It seems this is same as bug 257997.

Comment 4

[O. Atsushi (Torisugari)]

(In reply to comment #3)
> It seems this is same as bug 257997.

No, forget that.
Sorry for bug spam.

Anyway I'll write a patch. 

Comment 5

[Nickolay_Ponomarev]

>I am? nope.
Oops sorry :)

will you include 'if("extensionID" in e)' in this patch?

Comment 6

[O. Atsushi (Torisugari)]

Attachment: patch v1.0

Comment 7

[adler]

I have both situations:
'This item will be uninstalled after you restart Firefox'
'This item will be installed after you restart Firefox'

And restarting of FF has no effect. :(

I also installed several extensions but I don't see them anywhere, like
QuickNote, Sage, Gmail...
This is the version I have:
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Comment 8

[Nickolay_Ponomarev]

The code was heavily modified, and I think that the symptoms were cured, but the
problem (attempts to add a property to exception object that may well be a
wrappednative) is still there, I think.

Comment 9

[Przemyslaw Bialik]

(In reply to comment #8)

The bug has not changed on latest trunk (extension is stuck as before).
BTW choosing 'About...' from 'stucked' extension freezes EM.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050403
Firefox/1.0+

Comment 10

[Przemyslaw Bialik]

WFM, after accepting 'chrome registration failed' alert you can uninstall the
extension.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050526
Firefox/1.0+

Bug 295680 filled.

Comment 11

[db]

I can confirm that this bug occurs with other extensions too, for me it was Ad
Block and Web Developer that didn't uninstall properly.

I tried the instructions at
<http://kb.mozillazine.org/Firefox_:_FAQs_:_Uninstall_Extensions> but it failed,
probably because I couldn't find any entries like:

<RDF:li>chrome://[shortname]/[path to file]</RDF:li>

(there where other entries but they didn't use the chrome:// scheme)

Comment 12

[Robert Strong (they/them - no direct email)]

Is this still a problem with Firefox 1.5?

Comment 13

[adler]

works for me now (FF 1.5).

Comment 14

[Robert Strong (they/them - no direct email)]

This is WFM in Firefox 1.5