266986 - system font code leaks pango font objects

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect, P2)

Description

[Andrew Tong]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040809
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) 

I found memory leak in xft in mozilla1.4 on sparc. 
I use libumem.so and mdb on solaris to detect memory leak.
You can visit this page for more detail for libumem.so:
http://www.unixville.com/?q=node/view/85

236400 bytes for 2955 allocations with data size 80:
         libumem.so.1`umem_cache_alloc+0x13c
         libumem.so.1`umem_alloc+0x60
         libumem.so.1`malloc+0x28
         libglib-2.0.so.0.400.1`g_malloc+0x18
         libglib-2.0.so.0.400.1`g_strdup+0x1c
         libpangox-1.0.so.0.400.1`pango_x_insert_font+0x74
         libpangox-1.0.so.0.400.1`pango_x_font_map_for_display+0x154
         libgfx_gtk.so`void xlfd_from_pango_font_description+0x88
         libgfx_gtk.so`unsigned
nsSystemFontsGTK::GetSystemFontInfoconst+0xb8
         libgfx_gtk.so`nsSystemFontsGTK::nsSystemFontsGTK #Nvariant
1+0x16c
         libgfx_gtk.so`unsigned
nsDeviceContextGTK::GetSystemFontconst+0x44
         libgklayout.so`void SetFont+0x278
         libgklayout.so`const
nsStyleStruct*nsRuleNode::ComputeFontData+0x460
         libgklayout.so`const
nsStyleStruct*nsRuleNode::WalkRuleTree+0x2f4
         libgklayout.so`const nsStyleStruct*nsRuleNode::GetFontData+0x70
[e-mail] 10/29/04 09:35 GMT

Reproducible: Always
Steps to Reproduce:
1. $ LD_PRELAD=libumem.so
$ export LD_PRELOAD
$ UMEM_DEBUG=default
$ export UMEM_DEBUG
$ mdb ./mozilla-bin
>::run
visit web page: http://s1lab71.japan/memleak/memoryleak.html
close mozilla
>::umausers
Then you can see some memory leak informations.

Comment 1

[Boying Lu]

[Environment]
SunOS cycling 5.10 s10_67 sun4u sparc SUNW,Sun-Blade-100
Cinnabar build 20

[Steps to reproduce]
1.start mozilla at client
2.go through Menu->Edit->Preference->Mail and Newsgroups->Return Receipts
3.check "Never send a return receipt" but not save
4.check "Allow return reciepts for some messages"

[Expected Result]
three dropdown lists for different cases can be selected


[Actually Result]
three dropdown lists are all grayed and disabled
[e-mail] 10/20/04 07:58 GMT

Comment 2

[Boying Lu]

sorry, I post the message in a wrong window, Please ignore the above messages

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'd guess that we're supposed to do |g_object_unref(fontmap)|, but I haven't
checked.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

But according to the source code we're not.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch (checked in to trunk, 2004-12-17 12:36 -0800)

not yet tested.

Isn't it wonderful that I have to read the source code for pango to see which
functions ref and which don't?

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Taking, although it's worth noting that the actual leak reported may not be
fixed since it's stored by pango in a global variable, and we may not call
whatever causes what's in that global variable to be freed.

Comment 7

[Andrew Tong]

The memory leak exists after patching mozilla with patch above(id=164423).

Comment 8

[Mats Palmgren (inactive)]

gfx/src/gtk/ has been removed on trunk.
Does this bug still occur in a recent trunk build?
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/

Comment 9

[Zack Weinberg (:zwol)]

Since a patch was checked in and we have no reason to believe there is still a leak, marking fixed.  Please file a new bug if you can still see a leak with a current build.