267027 - All Views (Day/Week/Multiweek/Month) are too wide in many localizations

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1
Build Identifier: cvs

All views (Day view, Week view, Multiweek view, Month View) are too wide in many
localizations.  For example, in fr-FR the minimum window width is 1112 pixels. 
If the window is narrower, the right side of the view is cut off and there is no
scroll bar.

Reproducible: Always
Steps to Reproduce:
1. Install mozilla suite fr-FR lang pack (edit|preferences|appearance|Languages)
2. Install calendar.xpi (must be after lang pack)
3. mozilla -UILocale fr-FR -calendar

Actual Results:  
All views are much too wide, describe in details above.  Does expand to fill
window if wider than 1112 pixels, but does not shrink narrower than that.

Expected Results:  
views should permit much narrower window, as in en-US locale.

Comment 1

[gekacheka]

Attachment: weekview: allow all day left title to wrap; move bottom border from all day cells to header box

Problem is in WeekView.

Localizations may have long text for the left column label 
"All Day Events".  For example, fr-FR has 
"Événement durant toute la journée".  Other localizations have nearly as
long text.

This text width is used for the minimum width of other columns.  (Columns are
equal width, so they take the max width of any column.)

The fix is to allow the left column label containing "All Day Events" to wrap. 
A label's text contents may wrap if it is specified in the element rather than
as a value attribute.

In fr-FR, the text can now wrap, and does so to 3 lines.  This causes another
problem: the line at the bottoms of this label cell and the other cells in the
row no longer line up.

The fix for this is to move the bottom border from the cells to the box
containing the header grid.

Comment 2

[gekacheka]

Comment on attachment 164116 [details] [diff] [review]
weekview:  allow all day left title to wrap; move bottom border from all day cells to header box

(Use "patch -l -p 2 -i file.patch")

Comment 3

[Mostafa Hosseini]

Comment on attachment 164116 [details] [diff] [review]
weekview:  allow all day left title to wrap; move bottom border from all day cells to header box

Patch checked in. Should the bug stay open for other views?

Comment 4

[gekacheka]

All views are in a <xul:deck> (think deck of cards, any one of which can be on
top).  The size of the deck is the size of the largest view, so the oversized
weekview was causing all the "cards" in the deck to be too large.  Fixing
weekview fixed the other views.

Thanks.

Comment 5

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!