Closed
Bug 267034
Opened 20 years ago
Closed 19 years ago
Improve nsIAlertsService documentation
Categories
(Core :: XUL, enhancement)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: Biesinger, Assigned: asqueella)
References
(Blocks 1 open bug, )
Details
Attachments
(2 files)
|
3.03 KB,
patch
|
mscott
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
|
6.38 KB,
patch
|
Details | Diff | Splinter Review |
from bug 260865 comment 2: <biesi> 1. can the listener be null <biesi> 2. can I put up an alert when a previous one is up <biesi> 3. what happens if I try 2 comments should use doxygen-style
Comment 1•20 years ago
|
||
Since toolkit has the same issue, it'd be nice to have the patch for this cover both.
| Assignee | ||
Comment 2•19 years ago
|
||
Makes the comments doxygen-style, gives a bit more information. (The XPFE version is almost the same, I'll make a patch for it after this one gets reviewed.) Current alerts implementation doesn't deal very well with the situation of two simultaneous notifications - it displays two (overlapping) alerts, - but I think that we should fix instead of documenting it.
Assignee: jag → asqueella
Status: NEW → ASSIGNED
| Assignee | ||
Updated•19 years ago
|
Attachment #207941 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #207941 -
Flags: review?(mscott)
| Assignee | ||
Updated•19 years ago
|
Summary: Improve nsIAlertService documentation → Improve nsIAlertsService documentation
| Assignee | ||
Comment 3•19 years ago
|
||
BTW, is it a good idea to link to MDC documentation from the IDL? http://developer.mozilla.org/en/docs/nsIAlertsService
Updated•19 years ago
|
Attachment #207941 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Updated•19 years ago
|
Attachment #207941 -
Flags: review?(mscott) → review+
| Assignee | ||
Comment 4•19 years ago
|
||
now with the same changes for XPFE
| Assignee | ||
Updated•19 years ago
|
Whiteboard: [checkin needed]
Comment 5•19 years ago
|
||
mozilla/xpfe/components/alerts/public/nsIAlertsService.idl; new revision: 1.7; mozilla/toolkit/components/alerts/public/nsIAlertsService.idl; new revision: 1.6;
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha
You need to log in
before you can comment on or make changes to this bug.
Description
•