267046 - CVS user name not showing up in history log

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations: Projects, task, P2)

Description

[u60234]

My CVS user name, "jasajudeju%telia.com", is not showing up in the history log
for files I have committed.
The checkin is instead attributed to "uid665". See
http://bonsai.mozilla.org/cvsgraph.cgi?file=mozilla/browser/locales/sv-SE/README.txt
for one example of this.
Is the setup of my account not really finished yet?

Comment 1

[Dave Miller [:justdave]]

hmm, that's correct.  Your account was missing a piece of the setup.  I just
fixed it.  Existing checkins will forever have the uid665 moniker, but new
checkins should show up correctly now.

Leaving the bug open for now until we determine how it got missed.  It's all
part of the same script, so unless the person who created your account didn't
use the script for some reason, the script might be broken.

Comment 2

[u60234]

There are other accounts who have the same problem. Someone in the cs-CZ
localization team is called "uid 642",
http://bonsai.mozilla.org/cvsgraph.cgi?file=mozilla/browser/locales/cs-CZ/README.txt
 

And in fr-FR there is a "uid 667",
http://bonsai.mozilla.org/cvsgraph.cgi?file=mozilla/browser/locales/fr-FR/chrome/browser/browser.dtd

CC:ing the likely people behind these monikers.

Comment 3

[Benoit]

Hi, I'm uid667 :)

My CVS checkins are indeed marked as "[e-mail]", but I was told to not
worry about it for now. If you don't mind to fix it, my username is
benoit.leseul%gmail.com. 

I've heard of other people sharing the same "uid" on IRC #l10n but I don't
remember who it was.

Comment 4

[Benjamin Smedberg]

Dave, these are all loccalizer accounts, so perhaps "the script" needs a version
for localizers.

Comment 5

[Dave Miller [:justdave]]

(In reply to comment #4)
> Dave, these are all loccalizer accounts, so perhaps "the script" needs a version
> for localizers.

Yeah, that was indeed the case.  I hadn't gotten back to this bug since then,
but Chase and I were discussing it on IRC yesterday and discovered that the
adduser script for the l10n repository wasn't adding the users to the
/etc/passwd file inside the cvs chroot jail (the main adduser script did this).
 The lines to do this from the main script got copied into the l10n script last
night, so any future accounts should be okay.  Any existing once we'll need to
track down and update though.  Best course at this point is probably to write a
script to compare the root level /etc/passwd to the one in the jail and fill in
the missing ones.

Comment 6

[Benoit]

I've made some checkins this week on the l10n trunk and saw in the CVS log they
were still marked as "uid667". 

Could you please manually fix my account to be named "benoit.leseul%gmail.com"?
Thanks in advance.

Comment 7

[Dave Miller [:justdave]]

since this is going to require a few hours of playtime, it's a project.  Taking, since I'm going to be messing with cvs stuff next month anyway.

Comment 8

[Reed Loden [:reed]]

What's the latest on this?

Comment 9

[Dave Miller [:justdave]]

sounds like a good intern project ;)

I just dropped the production passwd file and the one from the jail in your home directory on boris.

Comment 10

[Reed Loden [:reed]]

Found four issues with homedir inconsistencies, which were then fixed, but the users themselves are in sync already.