267079 - remove *WithConversion from docshell

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

since URIs are UTF-8, this should improve correctness.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 164131 [details] [diff] [review]
patch

ok, this is wrong. the code here meant to check the start of the string only;
not all of it.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 164134 [details] [diff] [review]
patch v2

r=bzbarsky

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in docshell/base/nsDefaultURIFixup.cpp;
/cvsroot/mozilla/docshell/base/nsDefaultURIFixup.cpp,v  <--  nsDefaultURIFixup.cpp
new revision: 1.41; previous revision: 1.40
done


I'll check the nsDocShell part in with bug 157004 rather than here, so that I
don't have to merge the patches...