Closed
Bug 267079
Opened 21 years ago
Closed 21 years ago
remove *WithConversion from docshell
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha5
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
Attachments
(1 file, 1 obsolete file)
|
3.06 KB,
patch
|
bzbarsky
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
since URIs are UTF-8, this should improve correctness.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #164131 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 2•21 years ago
|
||
Comment on attachment 164131 [details] [diff] [review]
patch
ok, this is wrong. the code here meant to check the start of the string only;
not all of it.
Attachment #164131 -
Flags: review?(bzbarsky) → review-
|
|
Assignee | |
Comment 3•21 years ago
|
||
Attachment #164131 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•21 years ago
|
Attachment #164134 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → mozilla1.8alpha5
|
||
Comment 4•21 years ago
|
||
Comment on attachment 164134 [details] [diff] [review]
patch v2
r=bzbarsky
Attachment #164134 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Updated•21 years ago
|
Attachment #164134 -
Flags: superreview?(darin)
|
||
Updated•21 years ago
|
Attachment #164134 -
Flags: superreview?(darin) → superreview+
|
|
Assignee | |
Comment 5•21 years ago
|
||
Checking in docshell/base/nsDefaultURIFixup.cpp;
/cvsroot/mozilla/docshell/base/nsDefaultURIFixup.cpp,v <-- nsDefaultURIFixup.cpp
new revision: 1.41; previous revision: 1.40
done
I'll check the nsDocShell part in with bug 157004 rather than here, so that I
don't have to merge the patches...
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•