267089 - Remove nsIAlertListener from toolkit

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

see bug 260865, use nsIObserver instead.

Comment 1

[Alexander Opitz]

excuse for spam

Comment 2

[Alexander Opitz]

Attachment: patch v1

updating of toolkit to same state of xpfe.

In nsDownloadManager I removed the WIN_XP defines for the click event, cause on
XPFE they also don't exist and I don't know why Bug 229062 was only resolved
for XP_WIN. The ifdef XP_WIN in line 1414 makes no sense to me.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

the reason for those ifdefs is that until recently, nsIAlertListener.idl was
only compiled on windows, hence not having the ifdef would've broken the build

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 167164 [details] [diff] [review]
patch v1

looks good.  Tough to nit ports of things jag+neil reviewed!  doxygen-style
comments would indeed be good, hopefully that's covered in bug 267034

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

in:
@@ -1335,17 +1331,27 @@ nsDownloadManager::Observe(nsISupports* 

a return NS_OK; looks like it needs a bit of indentation

Comment 6

[Alexander Opitz]

Attachment: patch v1.1

fix indentation

Comment 7

[Alexander Opitz]

Attachment: patch v1.2

update to latest trunk

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in toolkit/components/alerts/public/nsIAlertsService.idl;
/cvsroot/mozilla/toolkit/components/alerts/public/nsIAlertsService.idl,v  <-- 
nsIAlertsService.idl
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/components/alerts/resources/content/alert.js;
/cvsroot/mozilla/toolkit/components/alerts/resources/content/alert.js,v  <-- 
alert.js
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/components/alerts/src/nsAlertsService.cpp;
/cvsroot/mozilla/toolkit/components/alerts/src/nsAlertsService.cpp,v  <-- 
nsAlertsService.cpp
new revision: 1.3; previous revision: 1.2
done
Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
/cvsroot/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp,v  <-- 
nsDownloadManager.cpp
new revision: 1.35; previous revision: 1.34
done
Checking in toolkit/components/downloads/src/nsDownloadManager.h;
/cvsroot/mozilla/toolkit/components/downloads/src/nsDownloadManager.h,v  <-- 
nsDownloadManager.h
new revision: 1.11; previous revision: 1.10
done

Comment 9

[Phil Ringnalda (:philor)]

+  else if (nsCRT::strcmp(aTopic, "allertclickcallback") == 0)

Could that double-l in allert be the reason clicking the alert doesn't actually
work?

Comment 10

[Alexander Opitz]

Attachment: fixing my faulty word

Comment 11

[Alexander Opitz]

checked in

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This missed the implementation in JS and thus caused part of bug 280603.