267119 - [FIX] anchor element without href but with tabindex can't receive focus

Status: RESOLVED WORKSFORME

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Martijn Wargers (dead)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041031 Firefox/0.9.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041031 Firefox/0.9.1+

This only happens in trunk (1.8a) builds (or only relevant in 1.8a builds).
See upcoming testcase.
An anchor element without the href attribute but with tabindex="1" set, is not
focusable, while it should be.

Reproducible: Always
Steps to Reproduce:
1. See testcase
2.
3.

Actual Results:  
Anchor element not focusable

Expected Results:  
Anchor element focusable.

Comment 1

[Martijn Wargers (dead)]

Attachment: Testcase

Comment 2

[Ralf Hauser]

related to Bug 267427 ?

Comment 3

[Mats Palmgren (inactive)]

Attachment: Testcase #2

Comment 4

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

This patch does minimal impact on ESM, but maybe the whole block:

    // Add better focusable test here later if necessary ...
    if (tag == nsHTMLAtoms::a &&
	testContent->IsContentOfType(nsIContent::eHTML)) {
      *aIsSelectionWithFocus = PR_TRUE;
    }
    else {
      *aIsSelectionWithFocus = testContent->HasAttr(kNameSpaceID_XLink,
nsHTMLAtoms::href);
      if (*aIsSelectionWithFocus) {
	nsAutoString xlinkType;
	testContent->GetAttr(kNameSpaceID_XLink, nsHTMLAtoms::type, xlinkType);

	if (!xlinkType.EqualsLiteral("simple")) {
	  *aIsSelectionWithFocus = PR_FALSE;  // Xlink must be type="simple"
	}
      }
    }

Can be replaced with:

*aIsSelectionWithFocus = testContent->IsFocusable(nsnull);

I'm not to sure about the various XLink types though... comments?

Comment 5

[Boris Zbarsky [:bzbarsky]]

> I'm not to sure about the various XLink types though... comments?

XLinks do the right thing for isFocusable ever since bug 261707 was fixed.  See
http://lxr.mozilla.org/seamonkey/source/content/xml/content/src/nsXMLElement.cpp#420

Comment 6

[Mats Palmgren (inactive)]

The "receive focus" part is worksforme.  Adding the focus outline style
is being fixed in bug 652301.