267139 - already deleted rss items are retrieved again if clicking get new messages while already retrieving rss items

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[David Arendt]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Build Identifier: Thunderbird version 0.8 (20040913)

already deleted rss items are retrieved again if clicking get new messages while
already retrieving rss items

Reproducible: Always
Steps to Reproduce:
1. click on rss folder
2. click get news messages
3. click again immediately get new messages

Actual Results:  
already retrieved rss items are retrieved again

Expected Results:  
I personally think the best would be simply ignoring the second get new messages
until retrieval is completed. An error message might be another solution.

Comment 1

[Scott MacGregor]

Attachment: the fix

Comment 2

[Scott MacGregor]

Comment on attachment 167158 [details] [diff] [review]
the fix

This fixes the problem reported here with checking a feed for new articles
while we are still processing a previous attempt to check for new articles for
the same feed.

Before downloading a feed, we now check our feed cache of active feed urls and
ignore the download request if we are already downloading the feed.

The risk here is that I miss a spot where I should be removing the feed from
the cache...

Note: this probably won't fix the weird thing with the mozilla zine aggregated
web log that is causing Hixie's posts to sometimes show up multiple times.

Comment 3

[Scott MacGregor]

fixed branch and trunk