Closed Bug 267160 Opened 15 years ago Closed 14 years ago

Visit URL button doesn't work in sunbird (needs to use external browser)

Categories

(Calendar :: Sunbird Only, defect)

Sunbird 0.2
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Sunbird 0.3

People

(Reporter: lorenzo, Assigned: mostafah)

References

Details

Attachments

(1 file)

The "Visit URL" button in the event properties dialog box doesn't work in
Sunbird. It just opens a new Sunbird window.

Steps to reproduce:

1. Double-click an event
2. Enter an URL in the URL field
3. Click the "Visit URL" button

Actual results:
A new sunbird main window opens

Expected results:
A browser opens at the event URL
Visit URL Button is opening another instance of the Sunbird application, not the
specified website.
The issue is in applicationUtil.js function launchBrowser. Changing the
navigator.vendor to "Mozilla Sunbird" and dumping exceptions shows that we need
to import the launchExternalURL method from Thunderbird/mailnews into Sunbird. 

Alternatively, is there/should there be something in toolkit to handle this?

version > SB 0.2RC1
Version: unspecified → Sunbird 0.2RC1
*** Bug 281151 has been marked as a duplicate of this bug. ***
(patch -l -p 2 -i file.patch)

Fix launchBrowser so it tries an existing browser window (for browser apps),
then tries to launch a browser window (for suite/seamonkey?), then falls back
to the external protocol service (for non-browser apps like sunbird,
thunderbird, etc.)

Tested with sunbird 20050813 on w2k, successfully opens page in firefox when
you click the "visit url" button in the event dialog.
Attachment #192769 - Flags: first-review?(mattwillis)
Component: General → Sunbird and Calendar-Extension Front End
Target Milestone: --- → Sunbird 0.3
QA Contact: gurganbl → sunbird
Blocks: 315373
Comment on attachment 192769 [details] [diff] [review]
appUtils.js:  fallback to nsIExternalProtocolService for non-browser apps

Moving review request to jminta. gekacheka, can you verify that this patch still works as expected?
Attachment #192769 - Flags: first-review?(mattwillis) → first-review?(jminta)
I'm using this patch in my local build and together with 315373 it does "the right thing". Haven't tested the "Visit" button yet.
Comment on attachment 192769 [details] [diff] [review]
appUtils.js:  fallback to nsIExternalProtocolService for non-browser apps

Thanks for the patch! Looks good. r=jminta
Attachment #192769 - Flags: first-review?(jminta) → first-review+
patch checked in
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Version: Sunbird 0.2RC1 → Sunbird 0.2
You need to log in before you can comment on or make changes to this bug.