267160 - Visit URL button doesn't work in sunbird (needs to use external browser)

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Lorenzo Colitti]

The "Visit URL" button in the event properties dialog box doesn't work in
Sunbird. It just opens a new Sunbird window.

Steps to reproduce:

1. Double-click an event
2. Enter an URL in the URL field
3. Click the "Visit URL" button

Actual results:
A new sunbird main window opens

Expected results:
A browser opens at the event URL

Comment 1

[Thaddeus Kaul]

Visit URL Button is opening another instance of the Sunbird application, not the
specified website.

Comment 2

[Matthew (lilmatt) Willis]

The issue is in applicationUtil.js function launchBrowser. Changing the
navigator.vendor to "Mozilla Sunbird" and dumping exceptions shows that we need
to import the launchExternalURL method from Thunderbird/mailnews into Sunbird. 

Alternatively, is there/should there be something in toolkit to handle this?

version > SB 0.2RC1

Comment 3

[gekacheka]

*** Bug 281151 has been marked as a duplicate of this bug. ***

Comment 4

[gekacheka]

Attachment: appUtils.js: fallback to nsIExternalProtocolService for non-browser apps

(patch -l -p 2 -i file.patch)

Fix launchBrowser so it tries an existing browser window (for browser apps),
then tries to launch a browser window (for suite/seamonkey?), then falls back
to the external protocol service (for non-browser apps like sunbird,
thunderbird, etc.)

Tested with sunbird 20050813 on w2k, successfully opens page in firefox when
you click the "visit url" button in the event dialog.

Comment 5

[Simon Paquet [:sipaq]]

Comment on attachment 192769 [details] [diff] [review]
appUtils.js:  fallback to nsIExternalProtocolService for non-browser apps

Moving review request to jminta. gekacheka, can you verify that this patch still works as expected?

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

I'm using this patch in my local build and together with 315373 it does "the right thing". Haven't tested the "Visit" button yet.

Comment 7

[Joey Minta]

Comment on attachment 192769 [details] [diff] [review]
appUtils.js:  fallback to nsIExternalProtocolService for non-browser apps

Thanks for the patch! Looks good. r=jminta

Comment 8

[Joey Minta]

patch checked in