267172 - proposal for the fr-FR bookmarks

Status: RESOLVED FIXED

(Mozilla Localizations :: fr / French, defect)

Description

[Bugzilla FR]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.3) Gecko/20041026 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.7.3) Gecko/20041026 Firefox/1.0

This is a proposal for the bookmarks.html file in firefox 1.0 fr-FR

Reproducible: Always
Steps to Reproduce:

Comment 1

[Bugzilla FR]

Attachment: Patch for the modification in fr-FR bookmarks.html

Made by Benoit

Comment 2

[Benoit]

This also removes the Firefox Crew's Picks, according to bug #266457. 

Comment 3

[Benoit]

Attachment: better patch

Better patch, with a keyword to a localized dictionary (Voila.fr) and inline
icons.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

These bugs shouldn't be in Bookmarks (which is code-related stuff); there ought
to be a component for i18n, but for now, punt to General.

Comment 5

[Benjamin Smedberg]

Comment on attachment 164195 [details] [diff] [review]
better patch

Please do not request approval until review has been granted.

Comment 6

[Benoit]

Comment on attachment 164195 [details] [diff] [review]
better patch

Putting on hold, default bookmarks changed again with bug #266000 and we need
the URL for the localized Firefox Central from peterv.

(Besides that, there are no review flags in the Mozilla Localizations product)

Comment 7

[Benoit]

Attachment: Combined patch

New patch on the bookmarks taking account of bug #266000 and bug #266774 as
well as the new localized Firefox Central (URL given by peterv, not online
yet).

Also fixes some encoding glitches in default google search (should be UTF-8)
and an inaccuracy in the installer (the start page is not on Mozilla Europe)

Asking manual review to filip since the flag doesn't exist in this product yet.

Comment 8

[Benoit]

> New patch on the bookmarks taking account of bug #266000 and bug #266774 as
> well as the new localized Firefox Central (URL given by peterv, not online
> yet).

Sorry, does _not_ take #266774 in account (I was only starring at that bug at
the same time but it has not been fixed).

Comment 9

[Bugzilla FR]

Comment on attachment 164291 [details] [diff] [review]
Combined patch

Reviewed

It's ok for me.

(Review in the comment because of the lack of review flag in the edit
attachment window)

Philippe

Comment 10

[Benoit]

Checked in, with minor edits (feed URL for the live bookmark sample, link to the
same Firefox Central at both places).

Comment 11

[Benoit]

By discussion on #l10n, it seems I may not have been allowed to do this, since
the whole tree was frozen. 

I would like to apologize for that, we just received approval this morning, and
I didn't saw any advice on the newsgroup nor on the Mozilla-l10n tinderbox that
I both follow carefully. It was only advertised on the main Aviary-1.0
tinderbox, and I didn't checked that one. Hoping this will not cause too much mess.