267216 - Unary increment doesn't pass 'assigning' flag under JSCLASS_NEW_RESOLVE

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Mike McCabe]

js engine from the tip:

js> it.noisy=true
true
js> it.foo = 1
resolving its property foo, flags {qualified,assigning,}
adding its property foo, initial value 1
setting its property foo, new value 1
1
js> it.bar++
resolving its property bar, flags {qualified,,}
getting its property bar, current value undefined
resolving its property bar, flags {qualified,,}
adding its property bar, initial value NaN
setting its property bar, new value NaN
NaN

... I expected to see 'assigning' in the resolve printf for 'it.bar++'.  I used
this op to close named scopes to property creation (outside of 'var') for
Tellme... but unary ++ creates a hole!

Comment 1

[Mike McCabe]

From an email from Brendan:

> It's a bug -- can you file it at bugzilla.mozilla.org, Browser / 
> JavaScript Engine, cc'ing me and shaver?  Say something about "should  
> set and clear JSFRAME_ASSIGNING around assigning parts of ++ and -- 
> bytecode cases in the interpreter."  Thanks,

cc'ing shaver.  (Hi, Mike!)

Comment 2

[Brendan Eich [:brendan]]

Patch now.

/be

Comment 3

[Brendan Eich [:brendan]]

Attachment: fix

With this patch:

js> it.noisy=true
true
js> it.foo=1
resolving its property foo, flags {qualified,assigning,}
adding its property foo, initial value 1
setting its property foo, new value 1
1
js> it.bar++
resolving its property bar, flags {qualified,,}
getting its property bar, current value undefined
resolving its property bar, flags {qualified,assigning,}
adding its property bar, initial value NaN
setting its property bar, new value NaN
NaN
js>
finalizing it

/be

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 164456 [details] [diff] [review]
fix

Simple, perhaps branch-worthy -- thoughts?

/be

Comment 5

[Brendan Eich [:brendan]]

Fixed on trunk.  If anyone wants this on aviary and 1.7.x branches, speak fast.

/be

Comment 6

[timeless]

note to self: i'm not interested in this :)