267222 - Javascript based links cause empty tab to be opened.

Status: RESOLVED DUPLICATE of bug 251137

(Firefox :: Tabbed Browser, defect)

Description

[shwag]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1

A link such as  javascript:window.open('productdetail.php?id=45', '_top'); when
clicked on with the middle mouse button to be opened in a new tab, will cause
the new tab opened to be empty.  Very annoying after clicking a bunch of links
to find that all the tabs you opened are empty.  This can be tested at this URL
included with the bug. Either make the browser interepret the code so that it
can be opened in the tab, or to issue a warning to the user maybe.

Reproducible: Always
Steps to Reproduce:

Comment 1

[OstGote!]

This is a duplicate of Bug 138198. Please resolve it.

Middle-click doesn't work but left-click works now with FF 1.0, see "New
features" on http://www.squarefree.com/burningedge/releases/1.0.html.

Comment 2

[OstGote!]

(In reply to comment #1)
> This is a duplicate of Bug 138198. Please resolve it.

better dupe it to the firefox bug 251137

Comment 3

[Dan M]

Old bug, well known. It's the same problem in Firefox and the Suite. I'll leave
bug 251137 open only because it's filed specifically against Firefox, so perhaps
will prevent even more duplicate bugs being filed.

*** This bug has been marked as a duplicate of 138198 ***

Comment 4

[:Gavin Sharp [email: [e-mail]]]

*** This bug has been marked as a duplicate of 251137 ***

Comment 5

[Dan M]

You know? When I marked this bug a duplicate of 138198, that's what I meant,
goddamnit. In the end it doesn't much matter but I do hate being corrected by
bureaucrats.

Comment 6

[Dan M]

*** This bug has been marked as a duplicate of 138198 ***

Comment 7

[:Gavin Sharp [email: [e-mail]]]

This was reported as a firefox bug, thus it should be duped to the firefox
equivalent. I have absolutely no idea where the idea of me being a "bureacrat"
idea came from. I'm not going to get into a pissing match with you.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

*** This bug has been marked as a duplicate of 251137 ***

Comment 9

[Dan M]

Oh for petesake. You're more anal retentive than I am, Sharp. That's gotta be
painful. And a little more sure of yourself than circumstances warrant. All fine
qualities for winning a pointless argument. Enjoy.

Comment 10

[jag (Peter Annema)]

I disagree with your assertion that Firefox bugs can only be duped to other
Firefox bugs. If the actual bug lies in code shared with SeaMonkey ("Browser" in
the product list), the bug report should be updated to reflect that by changing
the product and component fields to the correct values. Similarly, if a bug
report already exists under "Browser", it is perfectly ok to mark the "Firefox"
bug a duplicate of the "Browser" report. If you _wish_ to create more work for
yourself, you could update the product and component fields first, then dupe it.

Looking at this bug, it seems like we'll probably need back-end support for
fixing this as well as support in both front-ends, where the front-end changes
would be similar enough that I'd say we can deal with it all in one bug. So
personally I would've marked both this and bug 251137 dupes of bug 138198.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #10)
> I disagree with your assertion that Firefox bugs can only be duped to other
> Firefox bugs.

I never made the assertion that Firefox bugs can only be duped to other Firefox
bugs. In this case, there was an open browser bug and an open firefox bug for
the same issue. This was done to prevent dupes being filed against Firefox and
also because both need a different front-end change. I chose to dupe it to the
Firefox bug. No big deal. I certainly didn't expect DanM to react the way he
did. I think we can agree that there are more important things to do than to
fight about who's resolution was more correct. Let's put this to rest, please :).