267318 - patches for the alert dialogs and qt designer plugin

Status: RESOLVED FIXED

(Core Graveyard :: Ports: Qt, defect)

Description

[Michal Ceresna]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040917 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040917 Firefox/0.9.3

Hello,

these are first patches for merging from the Lixto code:
alter dialogs in qgeckoembed
qt-designer plugin with qgeckoembed

Michal

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Michal Ceresna]

Attachment: alert dialogs

Comment 2

[Michal Ceresna]

Attachment: qt-designer plugin

Comment 3

[Michal Ceresna]

(In reply to comment #1)
> Created an attachment (id=164282)
> alert dialogs

there is a config/ subdir with the build rules for .ui files,
this should be merged into <mozroot>/config/rules.mk

Comment 4

[Zack Rusin]

(In reply to comment #2)
> Created an attachment (id=164283)
> qt-designer plugin

Looks great, except two things: could you use QLibrary, instead of dlopen and
there's a typo in the includeFile method.

Comment 5

[Zack Rusin]

Benjamin could you also check the build system part of this one?

Comment 6

[Benjamin Smedberg]

This looks fine from a build-config perspective.

Comment 7

[Michal Ceresna]

> Looks great, except two things: could you use QLibrary, instead of dlopen and
using QLibrary doesn't work, see comment in the patch

> there's a typo in the includeFile method.
fixed

Comment 8

[Michal Ceresna]

Attachment: designer plugin

Comment 9

[Zack Rusin]

Great. I just committed both parts. Thank you very much.