267342 - "pacUtils" code should be unescaped

Status: RESOLVED WORKSFORME

(Core :: Networking, defect, P5)

Description

[benc]

as I understand it, because we do:

      var mypac = pacUtils + pac;

This creates a monster pile of javascript PAC goo by mashing pacUtils and the
loaded PAC file together.

      evalInSandbox(mypac, ProxySandBox, pacURL);
      LocalFindProxyForURL=ProxySandBox.FindProxyForURL;

It would good for readability and other reasons to find a solution where
pacUtils is not escaped code in the source tree.

Comment 1

[Darin Fisher]

low-priority, patches welcome...

Comment 2

[Aaron Boodman]

Also, I noticed that ebay.com uses the document.domain property. I tried setting
the codebase of my script to the value of document.domain, and also to 'http://'
+ document.domain. Neither worked.

It's difficult for me to confirm whether this bug would occur on all sites that
have document.domain since I don't have a webserver handy that I can configure
like that.

However it seems likely that this isn't coincidence.

Comment 3

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 4

[Valentin Gosu [:valentin] (he/him)]

I think I fixed this one in bug 1751698.