267373 - unable to create virtual folder as subfolder

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[sairuh (rarely reading bugmail)]

found using 2004110105-0.9 on linux fc2. I found this while trying to create
virtual (saved search) folders as subfolders on my IMAP accounts --one thing I
should note is that each IMAP account (I use dreamhost) consists of a single
toplevel Inbox. that Inbox contains a bunch of subfolders, including the special
folders (Drafts, Sent, Junk, Trash) as well as user-created folders. here I'm
trying to create a subfolder under one of those user-created folders.

1. select File > New > Saved Search Folder
2. provide a name for the search (foo-1)
3. under the "Create as a subfolder of" dropmenu, I selected:

My IMAP account > Inbox > user-folder-1

in other words, "user-folder-1 on My IMAP account"

4. [optional] provide search criteria
5. click OK

results: the New Saved Search Folder dialog doesn't go away. I see the following
js error:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004003 (NS_ERROR_INVALID_POINTER) [nsIMsgDatabase.dBFolderInfo]"  nsresult:
"0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
chrome://messenger/content/commandglue.js :: CreateVirtualFolder :: line 1023" 
data: no]

interestingly, if I collapse then re-expand the tree in the folder pane, I do
see the virtual folder "foo-1" listed there. however, when I click on it, I get
an Alert dialog saying:

The current command did not succeed. The mail server responded: Mailbox does not
exist, or must be subscribed to..

and then another js error appears:

Error: [Exception... "Component returned failure code: 0x80004003
(NS_ERROR_INVALID_POINTER) [nsIMsgDBView.open]"  nsresult: "0x80004003
(NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
chrome://messenger/content/commandglue.js :: CreateBareDBView :: line 671" 
data: no]
Source File: chrome://messenger/content/commandglue.js
Line: 671

not sure if what I see is another variation of bug 265533, except that I don't
crash.

Comment 1

[Scott MacGregor]

this may be linux only.

This works fine for me on Windows. I can create it as a sub folder of another
folder and I can even drag an exisitng VF to be a child of another regular IMAP
folder. 

Comment 2

[sairuh (rarely reading bugmail)]

I can repro this on Mac OS X 10.3.5 (2004110102-0.9).

Comment 3

[Marcia Knous [:marcia]]

I see this on the mac too, using yesterday's build. I see this error in the JS
console:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004003 (NS_ERROR_INVALID_POINTER) [nsIMsgDatabase.dBFolderInfo]"  nsresult:
"0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
chrome://messenger/content/commandglue.js :: CreateVirtualFolder :: line 1022" 
data: no]

If I continue and click OK again, it tells me I can't create the folder since
there is already one with that name.

Comment 4

[Scott MacGregor]

This worked for me using a debug OS X build I made fresh today. Let's try
retesting this again when we have OS X builds come out today / tomorrow. 

I'll ask Marcia to try it out on my up to date Mac build too to see if she can
reproduce it there.

Comment 5

[sairuh (rarely reading bugmail)]

still a problem using 2004110304-0.9 on linux fc2. I'll check on mac once the
download completes.

Comment 6

[Marcia Knous [:marcia]]

I also still see this using the Mac 2004-11-03-12-0.9 build. I do get the same
behavior that Sarah sees - upon initial creation, I don't see the folder listed.
If I drag and drop and existing folder to the same folder, then suddenly I do
see the Virtual Folder created, but when I click on it it gives me an error.

Comment 7

[Tom Hessman]

I've also seen this issue on Mac OS X with Thunderbird 0.9, although I don't
seem to be able to reproduce it every time.  Also, I've noticed that after
seeing this bug and then quitting and restarting Thunderbird, the virtual
folders that were created as subfolders of a real folder are gone.  Since that
also occurs when creating a virtual folder and then dragging it into a real
folder (without seeing any issues described by this bug), I filed bug 267865 for it.

Comment 8

[neomjp]

Similar problem for a POP account only when the parent_mailbox.sbd do not exist
(Thunderbird version 0.9 (20041103) for Mac OS X).

I mean by "similar" that the same things happen as comments #0 and #3, except
for "The mail server responded: Mailbox..." alert.

Everything worked fine when parent_mailbox.sbd already existed.

Comment 9

[Marcia Knous [:marcia]]

After discussing with Sarah, we both think this should be in the 1.0 bucket.
Moving to 1.0 target milestone.

Comment 10

[Ulf Uhrmann]

Same behaviour for me on Win2k using Tbird nightly 20041110 without IMAP.
I can save searches as root folder, but it doesn't work on subfolders.
Save search dialog doesn't close on "OK".
The virtual folder often doesn't appear, I have to close an reopen the according 
account-tree first.
After this the virtual folder is listed, but doesn't work (doesn't show up any 
search results).

Tested and confirmed with both existing new profile.

Comment 11

[David :Bienvenu]

Attachment: fix for imap case

I could not reproduce the pop3 problem, but I could reproduce the imap one, and
this patch fixes it...

Comment 12

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #11)
> I could not reproduce the pop3 problem

David, POP3 problem occurs only when ".sbd" directry does not exist as neomjp
said in comment #8.
 (1) ".sbd" directry exists
    (1-1) Create a usual mail folder of "P1"
    (1-2) Create a subfolder of "A"(usual folder) under "P1"
          => "P1.sbd" is created 
    (1-3) Create a virtual folder under "P1" folder => Successfull
 (2) ".sbd" directry does not exist
    (2-1) Create a a usual mail folder of "P2"
          => "P2.sbd" directry is not created yet
    (2-2) Try to create a virtual folder under "P2" folder
          => Fails

Comment 13

[Scott MacGregor]

Comment on attachment 165761 [details] [diff] [review]
fix for imap case

thanks for fixing this david.

Comment 14

[David :Bienvenu]

I was able to recreate this for local folders, and the fix will be similar
(though I will probably move some code into the base class to fix this)

Comment 15

[David :Bienvenu]

Attachment: fix local and pop3 cases

Comment 16

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #15)
> fix local and pop3 cases

POP3 problem has been resolved by nightly latest-0.9 2004/11/14 build.
However, problem still occurs on nightly latest-trunk 2004/11/14 build.
"Aviary 1.0" means "latest-0.9" branch only?

Comment 17

[David :Bienvenu]

yes, you'll notice I didn't mark it fixed, meaning I didn't check the fix into
the trunk yet. I will soon.

Comment 18

[David :Bienvenu]

fixed on trunk.

Comment 19

[sairuh (rarely reading bugmail)]

david, thanks for fixing this! works nicely with 2004111505-0.9 on linux fc2.

marcia, how does this work for you on mac and windows?

Comment 20

[Marcia Knous [:marcia]]

Verified fixed on Mac using TBird Branch 2004-11-15-02-0.9 bits. I can create a
subfolder on both my POP and IMAP accounts.  Will check Windows in a moment.

Comment 21

[Marcia Knous [:marcia]]

Verified on Windows TB Branch 2004-11-15-05-0.9. Looks like we got the trifecta.

Comment 22

[sairuh (rarely reading bugmail)]

thanks for checking marcia!