267379 - ###!!! ASSERTION: nsIDOMChromeWindow::SetTitle is deprecated, use nsIDOMNSDocument instead: 'Error',

Status: RESOLVED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[timeless]

###!!! ASSERTION: nsIDOMChromeWindow::SetTitle is deprecated, use
nsIDOMNSDocument instead: 'Error',
 file r:/mozilla/dom/src/base/nsGlobalWindow.cpp, line 5520
Break: at file r:/mozilla/dom/src/base/nsGlobalWindow.cpp, line 5520
0 [native frame]
1 ChangeCaption(aCaption = "Manage User Profiles")
["chrome://communicator/content/profile/profileManager.js":280]
    caption = [object XULElement @ 0x3a6be50]
    this = [object ChromeWindow @ 0x4268140]
2 SwitchProfileManagerMode()
["chrome://communicator/content/profile/profileManager.js":270]
    prattleIndex = 1
    captionLine = "Manage User Profiles"
    buttonDisplay = null
    selItems =
    profileList = [object XULElement @ 0x3db0878]
    deck = [object XULElement @ 0x3956820]
    this = [object ChromeWindow @ 0x4268140]
3 anonymous(event = [object Event @ 0x4032950])
["chrome://global/content/bindings/dialog.xml":275]
    this = [object ChromeWindow @ 0x4268140]
4 _fireButtonEvent(aDlgType = "extra2")
["chrome://global/content/bindings/dialog.xml":276]
    event = [object Event @ 0x4032950]
    noCancel = true
    handler = "SwitchProfileManagerMode();"
    fn = [function]
    returned = undefined
    this = [object XULElement @ 0x3c03de8]
5 _doButtonCommand(aDlgType = "extra2")
["chrome://global/content/bindings/dialog.xml":250]
    button = [object XULElement @ 0x3a945d0]
    noCancel = undefined
    this = [object XULElement @ 0x3c03de8]
6 _handleButtonCommand(aEvent = [object MouseEvent @ 0x4032420])
["chrome://global/content/bindings/dialog.xml":239]
    this = [object XULElement @ 0x3a945d0]
7 [native frame]

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

there is also a warning:

Warning: redeclaration of var errorMessage
Source File: chrome://communicator/content/profile/profileManager.js
Line: 114, Column: 12
Source Code:
        var errorMessage = checkProfileName(newName);

taking it.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

duh! I can change bug to ASSIGNED without reassigning it to myself? Odd...

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch

patch for both issues.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch v2

fixed indentation

Comment 5

[[e-mail]]

Other possible abuses of window.title:
/extensions/inspector/resources/content/inspector.js, line 265
 -- aWindow.title = this.mCurrentSearch.getItemDescription(idx);
/security/manager/pki/resources/content/serverCertExpired.js, line 55
 -- window.title = title;
/calendar/resources/content/printDialog.js, line 152
 -- printwindow.title = printwindow.name ; 

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

yeah. i'm making a patch for it and sending it to bug 264102

Comment 7

[Ian Neal]

Tested patch and works fine on WinXP SP2. I'd suggest asking neil for an r/sr

Comment 8

[Ian Neal]

Comment on attachment 164327 [details] [diff] [review]
patch v2

Checking in profileManager.js;
/cvsroot/mozilla/profile/resources/content/profileManager.js,v	<-- 
profileManager.js
new revision: 1.62; previous revision: 1.61
done

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

fixed