267475 - Clicking links to JPEG file with Chinese name download the file instead of displaying it in browser

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[[e-mail]]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20041026 Firefox/1.0RC1

When clicking at any of the links to JPEG files with Chinese filename in the
page, FireFox downloads the file instead of displays the file in the browser window.

Reproducible: Always
Steps to Reproduce:
1. Go to the URL.
2. Click at any of the JPG links with Chinese names.


Actual Results:  
FireFox shows the "Opening..." dialog and asks to choose what to do with the file.

Expected Results:  
Display the picture directly within FireFox window.

Comment 1

[Phil Ringnalda (:philor)]

Odd. The site's headers appear to be invalid, since it should specify
content-disposition: inline; filename=... and the filename should be encoded
according to RFC 2231, but it seems odd that bad characters in the filename
would force treating it as attachment, when the same headers without character
issues doesn't.

Same result in Seamonkey: --> Browser.

Comment 2

[Jungshik Shin]

Attachment: patch

This will 'fix' this problem (I've already tested it). However, I'm not sure
whether we have to do this because as noted in the previous comment, this is
actually an 'evangelism' issue.

Comment 3

[Jungshik Shin]

Boris, what do you think of attachment 164572 [details] [diff] [review]? It's a bit hackish, but we may
have to. An alternative is to tweak (a) nsIMIMEHeaderParam method(s). 

Comment 4

[Boris Zbarsky [:bzbarsky]]

That approach looks fine, but why the QIing?  originCharset is an nsIURI property...

Comment 5

[Jungshik Shin]

Attachment: patch update

Thanks. I got rid of QIing.

Comment 6

[Jungshik Shin]

Comment on attachment 164850 [details] [diff] [review]
patch update

asking for r/sr

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 164850 [details] [diff] [review]
patch update

hmm...
 95	NS_ASSERTION(!aTryLocaleCharset, "aTryLocaleCharset not yet supported
!");

but sure. r=biesi

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 164850 [details] [diff] [review]
patch update

sr=bzbarsky

Comment 9

[Jungshik Shin]

Attachment: patch for branches (1.7 and av1)

This is identical to attachment 164850 [details] [diff] [review] as far as what this patch touches is
concerned. The difference lies in the 'surrounding' where EqualsIgnorecase is
used in place of EqualsLowerCaseLiteral (which was intrdouced in 1.8 cycle).

Comment 10

[Jungshik Shin]

Comment on attachment 164984 [details] [diff] [review]
patch for branches (1.7 and av1)

carrying over r/sr from the trunk patch and asking for a to branches.

I came across this bug from time to time. It's not critical, but kinda 'glitch'
that may as well be removed in ff 1.0

Comment 11

[Jungshik Shin]

marking as fixed as this was checked into the trunk

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

this caused bug 269806

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 164984 [details] [diff] [review]
patch for branches (1.7 and av1)

If this didn't make it in for Firefox 1.0 then I don't think we want it for
1.7.x since those two are supposed to be gecko equivalents. Please re-request
if I'm wrong.