267477 - Make ChatZilla work in XULrunner

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[James Ross]

XULrunner is on its way, and it already compilable and usable on Windows (and
Linux I believe), so the time has come to make ChatZilla work with it...

I have no idea how we'd "install" CZ into XULrunner, though, so this will only
cover making the JAR work when patched into the XULrunner apps folder with
appropriate other files (e.g. a prefs file, icon, and installed-chrome.txt).

Comment 1

[James Ross]

Attachment: Makes ChatZilla work in XULrunner

This does some basic ground work to make ChatZilla work in XULrunner.

This includes a new way to detect the host application, and  changing the menus
to behave the same on XULrunner as in Firefox.

It moves some communicator scripts to overlays to only load them in seamonkey,
and sets a new default value for all messages.* prefs when in XULrunner (note
that the new value isn't actually supported in CVS yet).

Comment 2

[James Ross]

I've just found out that client.globalHistory isn't defined in XULrunner (it
doesn't have a history component?), so the lines at:

http://lxr.mozilla.org/mozilla/search?string=client.globalHistory

will break. This has currently only been observed as stopping stalking working,
instead making it match "undefined" only. Doing /eval
updateStalkExpression(this) from an affected network view fixes it temporarily.

Comment 3

[Seth McFarland]

The client.globalHistory seems to affect private messaging for me.  I get the
following error when trying to open a query window to a user:

[ERROR]	Internal error dispatching command “query”.
[ERROR]	TypeError: client.globalHistory has no properties @
<chrome://chatzilla/content/static.js> 1389

The real pain is that when users private message me I don't get an error or the
private message...

Comment 4

[James Ross]

Yeah, that is the same problem by the looks of it. The following script or /eval
should hopefully fix the problem for the session:

client.globalHistory = { addPage: function(){} };

Comment 5

[James Ross]

Comment on attachment 165061 [details] [diff] [review]
Makes ChatZilla work in XULrunner

Mostly moving code about and some whitespace cleanup, but the key bits are the
new content/sm/overlay.xul file, the goto-url changes, and the new 'host
detection' code.

Comment 6

[James Ross]

I've fixed the stuff from attachment 165061 [details] [diff] [review] in bug 269633.

Still need to fix the history stuff, though.

Comment 7

[James Ross]

Uh oh, looks like MSG_ERR_UNKNOWN_HOST is not defined. Luckly it doesn't care
unless it hits the actual line it is on... I'll add the message with the history
fix.

Comment 8

[James Ross]

Attachment: Safe-guards code against not having a global history

Comment 9

[Robert Ginda]

Comment on attachment 169198 [details] [diff] [review]
Safe-guards code against not having a global history

r=rginda

Comment 10

[James Ross]

Checked in the last attachment.

That should be all we need for now.