267478 - Cannot create log directories for servers containing non 6667 port

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Robin Berjon]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20041001 Firefox/0.10.1

The new scheme to put logs in more nested directories is really nice.
Unfortunately, some IRC servers use ports other than 6667 and when cz tries to
creates a directory called 'irc.foo.org:6665' it fails because of the colon (at
least on NTFS, haven't tried elsewhere). You probably want a dash instead.

Thankfully it fails smartly and simply complains that it cannot open the logfile.

You may wish to test this by hitting irc://irc.w3.org:6665/test

Reproducible: Always
Steps to Reproduce:
1. Connect to a server with a non default port
2. Try to turn logs on

Actual Results:  
Couldn't start logging

Expected Results:  
Logged happily, offered me a drink.

Comment 1

[James Ross]

Yeah, the escape code was only escaping things once...

I've got this all fixed locally for 0.9.66e.

Comment 2

[James Ross]

FIXED.

This fix will be available in the next ChatZilla release, 0.9.67.