267480 - XForms should use nsISchemaLoader

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Doron Rosenberg (IBM)]

Comment 1

[Doron Rosenberg (IBM)]

Attachment: attempt

Comment 2

[Darin Fisher]

Comment on attachment 164405 [details] [diff] [review]
attempt

>Index: extensions/xforms/nsXFormsModelElement.cpp

> nsXFormsModelElement::nsXFormsModelElement()
...
>+  mSchemas = do_GetService(NS_SCHEMALOADER_CONTRACTID);

It might be better to defer initialization of mSchemas 
until OnCreated is called.  One reason: even if it
doesn't happen now, this might result in re-entering
GetService while we are inside GetService, which is not
supported.  I'm not suggesting that this could happen
today, but maybe in the future if XTF changes slightly,
it could happen.  So, it might be better to defer until
OnCreated.  Anyways, there isn't any reason to do this
in the constructor, right?


>@@ -137,6 +141,7 @@

You might want to add "-p" on the command line when you
run cvs diff, so that it generates diffs that show the
functions being modified.  It makes reviewing much
easier :)


Otherwise, this patch looks fine to me.

r+sr=darin

Comment 3

[Doron Rosenberg (IBM)]

checked in,