267498 - Dialogs cutting off content

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Tracy Walker [:tracy]]

Seen on Windows Mozilla trunk build 2004-11-03-07-trunk

Dialogs have clipped text and check boxes.

Steps to reproduce:
-open a secure site 
If you hadn't previously turned off the warning dialog, notice that the security
dialog has text cuttoff by the buttons and you must guess if the checkbox is
checked or not. (screen shot of default browser dialog to follow)

Many dialogs exhibit this problem. Making this a smoketest blocker.

Comment 1

[Tracy Walker [:tracy]]

Attachment: cut off text and checkbox

Comment 2

[Asa Dotzler [:asa]]

Tracy, can you help with a regression window?

Comment 3

[Tracy Walker [:tracy]]

This regressed since yesterday afternoons build 2004-11-02-14-trunk on Windows.

Comment 4

[Philip K. Warren]

I am also seeing this on a Linux GTK2 trunk build from today.

Comment 5

[Philip K. Warren]

Potentially caused by the checkin for Bug 265165?

Comment 6

[Philip K. Warren]

Backing out the changes from Bug 265165 does seem to fix this problem.

Comment 7

[Philip K. Warren]

Attachment: Patch

Fix found by swalker.

Comment 8

[Philip K. Warren]

Comment on attachment 164475 [details] [diff] [review]
Patch

roc gave this r/sr in irc.

Comment 9

[Philip K. Warren]

Fixed.

Checking in nsSprocketLayout.cpp;
/cvsroot/mozilla/layout/xul/base/src/nsSprocketLayout.cpp,v  <-- 
nsSprocketLayout.cpp
new revision: 1.45; previous revision: 1.44
done

Comment 10

[Tracy Walker [:tracy]]

verified on Windows 2004-11-17-06-trunk