267506 - Reduce string copying from nsGenericHTMLElement::GetHrefURIForAnchors

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Brian Ryner (not reading)]

Since this method only needs a const string containing the attribute value, it
can use the buffer owned by the nsAttrValue and avoid copy plus (usually) malloc
cost.  This shows up fairly high on the profile for frame construction time on
certain pages, like the netscape.com page on the pageload test.  On that page,
without this patch, nsStyleUtil::IsHTMLLink takes 42% of time spent in
nsCSSFrameConstructor::ConstructFrame.  With this patch, it's down to about 15%.
(It looks like it hits this page hard because it has a lot of AREA elements).

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

In addition to what I said above, this also avoids a bit of buffer refcounting
in nsContentUtils::NewURIWithDocumentCharset.

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 164429 [details] [diff] [review]
patch

r+sr=jst

Comment 3

[Brian Ryner (not reading)]

checked in