Closed
Bug 267511
Opened 21 years ago
Closed 21 years ago
tons of assertions from bug 204784 fix
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: pkwarren)
Details
(Keywords: regression)
Attachments
(1 file)
|
1.25 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
The fix for bug 204784 causes a constant stream of assertions for me when
loading pages with form controls. The assertion is "no common ancestor at
all???" in
nsLayoutUtils::CompareTreePosition.
For more information, see:
https://bugzilla.mozilla.org/show_bug.cgi?id=204784#c27
and onwards.
|
Assignee | |
Comment 1•21 years ago
|
||
- Check that the parent node is non-NULL before calling CompareTreePosition.
This prevents the assertion.
- Change a comment to an NS_ASSERTION so we'll know if for some reason the QI
to nsIContent fails. This is to address Bug 204784 comment 25.
|
|
Assignee | |
Updated•21 years ago
|
Attachment #164444 -
Flags: superreview?(bzbarsky)
Attachment #164444 -
Flags: review?(cbiesinger)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 164444 [details] [diff] [review]
Patch v1
r+sr=bzbarsky
Attachment #164444 -
Flags: superreview?(bzbarsky)
Attachment #164444 -
Flags: superreview+
Attachment #164444 -
Flags: review?(cbiesinger)
Attachment #164444 -
Flags: review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
Fixed.
Checking in nsHTMLFormElement.cpp;
/cvsroot/mozilla/content/html/content/src/nsHTMLFormElement.cpp,v <--
nsHTMLFormElement.cpp
new revision: 1.176; previous revision: 1.175
done
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•21 years ago
|
Flags: blocking1.8a6?
Flags: blocking1.7.6?
|
|
||
Updated•21 years ago
|
Flags: blocking1.8a6?
|
||
Comment 4•21 years ago
|
||
try to lock down `1.7.6 to ship soon. not blocking for this one.
Flags: blocking1.7.6? → blocking1.7.6-
You need to log in
before you can comment on or make changes to this bug.
Description
•