Closed Bug 267523 Opened 20 years ago Closed 20 years ago

firebird-index1.rdf - &brandShortName; may not always start with "F"

Categories

(SeaMonkey :: Help Viewer, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8beta2

People

(Reporter: stas, Assigned: rjkeller)

References

()

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl-PL; rv:1.7) Gecko/20040616
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl-PL; rv:1.7) Gecko/20040616

Under the letter "f" in help viewer's index one can find a link "Firefox,
using". This is because of this piece of code in the firebird-index1.rdf file:

<rdf:Description about="#f">
  <nc:subheadings>
    <rdf:Seq>
      (...)
      <rdf:li><rdf:Description ID="firebird-using" nc:name="&brandShortName;,
Using" nc:link="using_firebird.xhtml"/></rdf:li>
      (...)
    </rdf:Seq>
  </nc:subheadings>
</rdf:Description>

And what if someone made their own browser, based on Firefox, and for example
named it "SampleBrowser"? The link "SampleBrowser, Using" would still be under "f".

Maybe the link should read "Using &brandShortName" and be placed under "U"?

Reproducible: Always
Steps to Reproduce:
It's worth considering after 1.0.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Firefox1.1
Beonex needs this, so taking...
Assignee: jwalden+fxhelp → rj.keller
Attached patch PatchSplinter Review
Removes &brandShortName;, Using entry, since Using &brandShortName; is already
in the glossary. I really doubt someone would look up Firefox in the index :).
Attachment #168574 - Flags: review?(steffen.wilberg)
Comment on attachment 168574 [details] [diff] [review]
Patch

I agree with comment 3.
Attachment #168574 - Flags: review?(steffen.wilberg) → review+
Fix checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Flags: review+
Product: Firefox → Toolkit
Target Milestone: Firefox1.1 → ---
Targetting bugs which were targetted to Firefox1.1 before the move to
mozilla1.8beta2.
Target Milestone: --- → mozilla1.8beta2
Product: Toolkit → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: