267539 - miscellaneous xforms submission bugs

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Darin Fisher]

miscellaneous xforms submission bugs:

1) EvaluateNodeBinding fails if <submission> element doesn't have a bind or ref
attribute, but the XForms 1.0 spec says that we should assume a ref of "/" by
default.  That rule applies to <submission>, but not to ordinary form controls.

2) Not able to submit with ref="/" since in that case XPath gives us a
nsIDOMDocument as the single node result.  In that case we don't want to call
GetOwnerDocument, we just want to QI the resulting node to nsIDOMDocument.

3) Support submission to a relative URL.

Comment 1

[Darin Fisher]

Attachment: v1 patch

Comment 2

[Darin Fisher]

fixed-on-trunk

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 164461 [details] [diff] [review]
v1 patch

   // uriSpec is already ASCII-encoded and absolutely specified
   nsCOMPtr<nsIURI> uri;
-  ios->NewURI(uriSpec, nsnull, nsnull, getter_AddRefs(uri));
+  ios->NewURI(uriSpec, nsnull, doc->GetDocumentURI(), getter_AddRefs(uri));

does that mean the comment is wrong? because if uriSpec were absolutely
specified, you wouldn't need to pass a base uri...

(and in case the comment is wrong about ASCII too, you could pass
doc->GetDocumentCharacterSet().get() ;) )

Comment 4

[Darin Fisher]

Attachment: v2 patch

thanks biesi!  i agree :)

Comment 5

[Darin Fisher]

Attachment: v2.1 patch

ok, that last patch included a bunch of fixes for xforms errata.  it wasn't
quite complete.  here's a better version.

Comment 6

[Darin Fisher]

v2.1 patch checked in on trunk.