267541 - Set create chart dataset checkbox to on by default

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, enhancement)

Description

[Vlad Dascalu]

<cardinal> Looking for some one that is familiar with the process of creating a
product?
<cardinal> At the bottom of the 'Add product' page, there is a check box that
says "Create chart dataset for this product:" What is this for?
<cardinal> I'm using 2.18rc3.
<kniht> whether it should collect data for the new charting system - when
collectstats script is run a by nightly cron
<cardinal> kniht: this only applies to the new charting feature?
<kniht> as far I know - but I can' say 100%
<kniht> and I am not sure how you would turn it on later if you didn't do when
you created the product
* vance (~[e-mail]) has
joined #mozwebtools
<cardinal> kniht: OK that is what I thought, but if I run collectstats it still
creates a data file for the product even if I do not not check the box? 
<cardinal> kniht: Is there anyone else who might know more about this feature?
<kniht> not sure who is the expert on charting - might be something you could
ask on the mailing list
<cardinal> kniht: OK, thanks. I'll keep playing around and post it on the
mailing list.
<kniht> or maybe someone else will answer here - people come and go at all hours
* LpSolit (~[e-mail]) has joined #mozwebtools
* KaiRo_away is now known as KaiRo
<justdave> there's old charts and new charts
<justdave> the old charting system automatically generates datafiles when you
add products.
<justdave> the new one automatically converts the existing data on an upgrade,
but prompts for adding datasets on new products
<justdave> originally that was because the entire system was either on or off
for a user and there weren't group controls on viewing the charts.
<justdave> between rc2 and rc3, group controls for individual datasets were added
<justdave> so that checkbox should probably default to on now
<justdave> since when it does that, it sets the new datasets to be restricted to
the same groups as the product

Comment 1

[Vlad Dascalu]

Attachment: patch

Comment 2

[Vlad Dascalu]

Attachment: patch

Comment 3

[Dave Miller [:justdave]]

you know what?  looking at the code, I can't find anything where it's tying a
series to a product (so it would know to match groups with it)...   Unless
someone can find said code and point it out to me, I think I'll wait for Gerv to
get back and clarify on this one...

Comment 4

[Vlad Dascalu]

CCing Gerv to be sure he got this.

Comment 5

[Gervase Markham [:gerv]]

Dave: it can't put the product to the groups its in because, having just been
created, it's not in any groups!

The solution here was supposed to be to direct people to the group-editing UI
for the charts after they had created the product. However, it appears that
there isn't yet any such UI. Bug 225687 comment 47 says:

"Things to do in a future patch, if Dave deems them necessary for 2.18:

- Add an admin UI for the groups each category is in (this is why, as Joel
noticed, no-one is currently changing category_group_map; I suspect this will
be deemed necessary :-)

..."

this didn't get filed as a separate bug, and isn't a dependency of bug 257346,
the charts-cleanup meta-bug. And I completely forgot about it.

Oops. I take full responsibility. What do we do? Document the current state and
rely on the chartgroup parameter to save us from information leaks?

Gerv

Comment 6

[Dave Miller [:justdave]]

How much effort is it to come up with a UI for this?  At the rate we're going I
think we still have a week or so yet before 2.18 makes it out the door.  Given
the security implications, I now see that's the reason this checkbox was off, so
this bug is thus a WONTFIX as stands, but because it was the same intent, to get
the charts visible, and there wasn't a bug for the other, perhaps this can
become it.

Comment 7

[Dave Miller [:justdave]]

not blocking 2.20 release per comment 6

Comment 8

[Max Kanat-Alexander]

So it sounds like this is important and requires bug 276230. However, I think it
would be a change in the default behavior of Bugzilla and seems like it should
go to 2.20. (Particularly with that approval2.18-).

Comment 9

[Frédéric Buclin]

gerv, what's the status of this bug?

Comment 10

[Frédéric Buclin]

Comment on attachment 164465 [details] [diff] [review]
patch

This part of editproducts.cgi has been templatized!

Comment 11

[A. Karl Kornel]

Well, since this is marked as an enhancement, it's probably not going to make 2.24.

Comment 12

[A. Karl Kornel]

Attachment: Patch v1.2

An unbitrotted version of attachment 164465 [details] [diff] [review], modifying the template instead of the CGI.

Gerv: You there?

Comment 13

[A. Karl Kornel]

Attachment: Patch v1.25

My CVS and SVN archives seem to be a bit out of sync.  Let's try this again.

Also, it seems "gerv@" isn't enough for a match.  I guess we have multiple Gerv's here! 8-)

Comment 14

[Gervase Markham [:gerv]]

Karl: what about the problem mentioned in comment #5? My memory is rusty, but I seem to remember that we still don't have any UI for restricting charts to certain groups, we only have a general "chartgroup" parameter. Don't we need to document the information leak risks of creating charts? Or does having them on by default not significantly effect the scope of that already-existing problem? What do you think?

Gerv

Comment 15

[Gervase Markham [:gerv]]

Comment on attachment 207248 [details] [diff] [review]
Patch v1.25

Removing review request; waiting on an answer to comment #14.

Gerv

Comment 16

[Frédéric Buclin]

This bug is retargetted to Bugzilla 3.2 for one of the following reasons:

- it has no assignee (except the default one)
- we don't expect someone to fix it in the next two weeks (i.e. before we freeze the trunk to prepare Bugzilla 3.0 RC1)
- it's not a blocker

If you are working on this bug and you think you will be able to submit a patch in the next two weeks, retarget this bug to 3.0.

If this bug is something you would like to see implemented in 3.0 but you are not a developer or you don't think you will be able to fix this bug yourself in the next two weeks, please *do not* retarget this bug.

If you think this bug should absolutely be fixed before we release 3.0, either ask on IRC or use the "blocking3.0 flag".

Comment 18

[Max Kanat-Alexander]

Bugzilla 3.2 is now frozen. Only enhancements blocking 3.2 or specifically approved for 3.2 may be checked in to the 3.2 branch. If you would like to nominate your enhancement for Bugzilla 3.2, set the "blocking3.2" flag to "?", and either the target milestone will be changed back, or the blocking3.2 flag will be granted, if we will accept this enhancement for Bugzilla 3.2.

Comment 19

[Frédéric Buclin]

Comment on attachment 207248 [details] [diff] [review]
Patch v1.25

This should be on by default, as it's easier to delete series than to create them later.

We can hold approval till the group UI is ready, though.

Comment 20

[Frédéric Buclin]

Holding approval per my previous comment.

Comment 21

[Frédéric Buclin]

We no longer accept new features for Bugzilla 3.6. Retargetting to 3.8.

Comment 22

[Max Kanat-Alexander]

LpSolit: Do you want to check in this patch?

Comment 23

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/admin/products/create.html.tmpl
Committed revision 7003.