267626 - fix for modal dialogs crash

Status: RESOLVED FIXED

(Core Graveyard :: Ports: Qt, defect)

Description

[Michal Ceresna]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040917 Firefox/0.9.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040917 Firefox/0.9.3

showing a modal (alert) dialog crashes the app due the dynamic cast

Reproducible: Always
Steps to Reproduce:
start dist/bin/mozilla
load about:config
click on some (string) entry
result: crash

(gdb) bt
#0  0x414aa7cd in __dynamic_cast () from /usr/lib/libstdc++.so.5
#1  0xb684ae71 in nsCommonWidget::SetModal ()
   from /home/ceresna/mozilla-cvs/mozilla/dist/bin/components/libwidget_qt.so
#2  0xb663212e in nsXULWindow::ShowModal ()
   from /home/ceresna/mozilla-cvs/mozilla/dist/bin/components/libnsappshell.so
#3  0xb663b2e3 in nsWebShellWindow::ShowModal ()
   from /home/ceresna/mozilla-cvs/mozilla/dist/bin/components/libnsappshell.so
#4  0xb662ffc1 in nsContentTreeOwner::ShowAsModal ()
   from /home/ceresna/mozilla-cvs/mozilla/dist/bin/components/libnsappshell.so
#5  0xb7707a87 in nsWindowWatcher::OpenWindowJS ()
   from /home/ceresna/mozilla-cvs/mozilla/dist/bin/components/libembedcomponents.so
#6  0xb7706a2b in nsWindowWatcher::OpenWindow ()
   from /home/ceresna/mozilla-cvs/mozilla/dist/bin/components/libembedcomponents.so
#7  0xb770d230 in nsPromptService::DoDialog ()
   from /home/ceresna/mozilla-cvs/mozilla/dist/bin/components/libembedcomponents.so
#8  0xb770c637 in nsPromptService::Prompt ()
   from /home/ceresna/mozilla-cvs/mozilla/dist/bin/components/libembedcomponents.so
#9  0xb7fddee7 in XPTC_InvokeByIndex () from ./libxpcom_core.so
#10 0xb76ecace in XPCWrappedNative::CallMethod ()

Comment 1

[Michal Ceresna]

Attachment: dynamic cast vs. modal dialogs

Comment 2

[Zack Rusin]

Ah, yes, I forgot to commit this. Fixed in CVS.