267643 - Virtual Folders: Delete has no confirmation

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[blujay]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7.3) Gecko/20041001 Firefox/0.10.1

If one has a virtual folder selected in the folder pane, and the folder pane has
focus, and one clicks the "delete" toolbar button, the virtual folder will
immediately be deleted.  Poof.  It's gone.  This is especially bad because it's
easy to think the message pane has focus and think you're deleting a message. 
Now I have to go recreate my virtual folders....  :(

Reproducible: Always
Steps to Reproduce:
1.  Make a virtual folder.
2.  Select it.
3.  Click the "Delete" button in the toolbar, or press the Delete key.

Actual Results:  
Virtual folder was deleted.

Expected Results:  
Personally, I think that pressing Delete or clicking Delete in the toolbar
should not do anything if the folder pane has focus.

At the very least, a confirmation box should appear before the virtual folder is
deleted.

Comment 1

[Stephen Walker]

http://lxr.mozilla.org/seamonkey/source/mailnews/imap/src/nsImapMailFolder.cpp#2324
http://lxr.mozilla.org/seamonkey/source/mailnews/local/src/nsLocalMailFolder.cpp#1060

Intentional?

Comment 2

[blujay]

Well, looking at those comments in the code, it does appear intentional.  But I
don't think it should be that way.  It's way too easy to accidentally delete a
virtual folder that took quite a while to set up the way you want it.  I mean,
deleting without confirmation is DOS stuff.  :)

Comment 3

[Marcia Knous [:marcia]]

Sarah and I reviewed this bug during the bug triage. This is expected behavior.
resolving as invalid. reporter - feel free to request this as an RFE if you so
desire.

Comment 4

[David :Bienvenu]

Attachment: proposed fix

enough people have complained about this that we're going to prompt now.

Comment 5

[David :Bienvenu]

*** Bug 271694 has been marked as a duplicate of this bug. ***

Comment 6

[Tracy Walker [:tracy]]

verified with Windows Thunderbird build 2004-11-30-05-0.9