User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20041001 Firefox/0.10.1 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20041001 Firefox/0.10.1 The recently checked in Irish l10n (bug 264743) has an out-of-date installer.inc; it's missing the COMPLETE_RESET_HOMEPAGE #define from bug 262953. This is breaking the windows tinderbox build: http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n-ga-IE We're not translating the installer so we just need the latest en-US version committed. Reproducible: Always Steps to Reproduce:
Ben, requesting review.
What's up with this patch? Are all the lines changed, or line-endings or something?
Status: UNCONFIRMED → NEW
Ever confirmed: true
(In reply to comment #3) Yup -- line endings changed per bug 257834. After the patch it should match the current en-US version.
So you want to convert the line endings back to DOS? That sounds wrong. Attachement 162938 supposedly converted to unix lineendings, which are the right ones in the repository. Could we either get a current patch or a -w one?
(In reply to comment #5) It looks like my patch is removing the DOS line endings as desired. The - lines ending 0D0A and the + lines end in 0A.
Am I free to commit when approval-aviary+ is set?
Yes, I believe you are free to commit this. Always check http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n for special tree notices (such as tagging) that might indicate otherwise.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.