267717 - updated installer.inc needed for Irish l10n

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Kevin Scannell]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20041001 Firefox/0.10.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20041001 Firefox/0.10.1

  The recently checked in Irish l10n (bug 264743) has an out-of-date
installer.inc; it's missing the COMPLETE_RESET_HOMEPAGE #define from bug 262953.

This is breaking the windows tinderbox build:
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n-ga-IE

We're not translating the installer so we just need the latest en-US
version committed.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Kevin Scannell]

Attachment: installer.inc patch

Comment 2

[Brian King [:kinger]]

Ben, requesting review.

Comment 3

[Benjamin Smedberg]

What's up with this patch? Are all the lines changed, or line-endings or something?

Comment 4

[Kevin Scannell]

(In reply to comment #3)

Yup -- line endings changed per bug 257834.
After the patch it should match the current
en-US version.

Comment 5

[Axel Hecht]

So you want to convert the line endings back to DOS? That sounds wrong.
Attachement 162938 supposedly converted to unix lineendings, which are the right
ones in the repository.
Could we either get a current patch or a -w one?

Comment 6

[Kevin Scannell]

(In reply to comment #5)

It looks like my patch is removing the DOS line endings as desired.
The - lines ending 0D0A and the + lines end in 0A.

Comment 7

[Kevin Scannell]

Am I free to commit when approval-aviary+ is set?

Comment 8

[Benjamin Smedberg]

Yes, I believe you are free to commit this. Always check
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla-l10n for special tree
notices (such as tagging) that might indicate otherwise.