Closed
Bug 267774
Opened 20 years ago
Closed 20 years ago
Remove unused variable in process_bug.cgi
Categories
(Bugzilla :: Creating/Changing Bugs, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
Attachments
(1 file)
733 bytes,
patch
|
kiko
:
review+
|
Details | Diff | Splinter Review |
The variable $newname in process_bug.cgi is never used. Remove it! (old code)
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #164615 -
Flags: review?(kiko)
Comment 2•20 years ago
|
||
Comment on attachment 164615 [details] [diff] [review] remove $newname Wow, this is *really* "taking a baby-steps attitude" into cleaning up process_bug :)
Attachment #164615 -
Flags: review?(kiko) → review+
Assignee | ||
Comment 3•20 years ago
|
||
(In reply to comment #2) > (From update of attachment 164615 [details] [diff] [review]) > Wow, this is *really* "taking a baby-steps attitude" into cleaning up > process_bug :) > Pffff..... This is only because I was looking at the code for another patch and found this. This has nothing to do with the clean up job you want me to do! ;) More "serious" patches will come later... :-p justdave, please let me know if you want it for 2.16.8 (the patch is not the same).
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval2.18?
Comment 4•20 years ago
|
||
nah, no point in messing with 2.16 for something that doesn't have any user-visible benefit.
Flags: approval?
Flags: approval2.18?
Flags: approval2.18+
Flags: approval+
Target Milestone: --- → Bugzilla 2.18
Comment 5•20 years ago
|
||
Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.216; previous revision: 1.215 done Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.205.2.6; previous revision: 1.205.2.5 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•