267823 - [BEOS] nsWindow.cpp contains ONWORKSPACE instead of nsWindow::ONWORKSPACE

Status: RESOLVED FIXED

(Core Graveyard :: GFX: BeOS, defect)

Description

[Niels Reedijk]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.7.3) Gecko/20041028 Firefox/1.0RC1
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.7.3) Gecko/20041028 Firefox/1.0RC1

From bug 242315 :

Also, bit off-topic -looking at your patch i noticed my own old mistake in
CallMethod() code. There is ONWORKSPACE: case in switch, but it is wrong - must
be something like nsWindow::ONWORKSPACE  there. Can you file new bug on that?
I will quickly review it, and if tree is open, will try for check patch in
before i leave my home (will be in Sweden from 7-th to 21-th October). So new
IME patch will be maid against new code with that stupid bug fixed.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Niels Reedijk]

Attachment: Quick one-liner

This should be applied to AVIARY and MAIN.

Quick one-liner.

Comment 2

[Sergei Dolgov]

Comment on attachment 164654 [details] [diff] [review]
Quick one-liner

r=[e-mail]

Comment 3

[Niels Reedijk]

Comment on attachment 164654 [details] [diff] [review]
Quick one-liner

Requesting aproval. This is a change in the BeOS code only. It will not affect
the other platforms in any way. The patch is reviewed.

Comment 4

[Niels Reedijk]

Comment on attachment 164654 [details] [diff] [review]
Quick one-liner

Requesting aproval. This is a change in the BeOS code only. It will not affect
the other platforms in any way. The patch is reviewed.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 164654 [details] [diff] [review]
Quick one-liner

a=asa

Comment 6

[Niels Reedijk]

Sergei, will you check this one in in the MAIN and AVIARY branches?

Comment 7

[Kenneth Herron]

Checked in on the trunk:

/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.86; previous revision: 1.85

and the aviary branch:

/cvsroot/mozilla/widget/src/beos/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.77.6.2; previous revision: 1.77.6.1

Comment 8

[Niels Reedijk]

Checked in. Fyysik is probably already packing up for his trip tomorrow. Landing
this bug affects the Japanese input patch.