267854 - Parser data listeners don't get all the data in all cases.

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Johnny Stenback (:jst)]

The parser data listener API that was added in bug 265334 for firefox 1.0 isn't
getting all the data that's parsed. The reason being that it reiles on being
able to reach the current nsIRequest through the parser context, but in certain
situations we receive data while we're processing data on a different context,
and that context won't have a request so when the call to nsParser::DataAdded()
comes through we don't find a nsIRequest in the current parser context
(mParserContext) and we don't feed the added data to the listners. This
essentially renders the new API useless, and must be fixed for 1.0.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Pass the nsIRequest from necko through to DataAdded().

This changes the code to pass the request that necko passes in to the parser
along to the scanner, so that it then can pass it back to the parser's
DataAdded() method. This is way more robust and correct than the current code.

Comment 2

[Johnny Stenback (:jst)]

blocking-aviary1.0 per discussion with Ben.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 164682 [details] [diff] [review]
Pass the nsIRequest from necko through to DataAdded().

r=bzbarsky

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 164682 [details] [diff] [review]
Pass the nsIRequest from necko through to DataAdded().

sr+a=me.

/be

Comment 5

[Johnny Stenback (:jst)]

Fixed on trunk and branches.