268010 - Uninstaller dialog that appears if Firefox is running should have a cancel button

Status: RESOLVED WORKSFORME

(Firefox :: Installer, enhancement)

Description

[Tom Hessman]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041103 Firefox/1.0RC2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041103 Firefox/1.0RC2

If you run Firefox's uninstaller while Firefox is open, it tells you that
Firefox is running, and that it needs to quit Firefox to continue.  It says that
it will automatically do so when you click OK, but there is no cancel button, so
you are forced to close Firefox and lose any data (I had 3 Bugzilla tabs open,
for example).

Reproducible: Always
Steps to Reproduce:
1. Open Firefox with at least one tab
2. Go to the Add/Remove Programs Control Panel
3. Attempt to uninstall Firefox

Actual Results:  
A window appears telling you that it needs to quit Firefox, and that it will do
so automatically when you click OK.

Expected Results:  
In addition to the OK button, there should be a Cancel button in case you don't
want it to quit Firefox for you.  After it quits Firefox you can still cancel
the uninstallation, but you should be able to cancel it before it forces Firefox
to quit.

Comment 1

[Andrey Melnikov]

Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050331 Firefox/1.0+

I would like to confirm the bug, but don't have enough privileges yet. The bug
is also a duplicate of Bug#250065

Comment 2

[Andrey Melnikov]

*** Bug 250065 has been marked as a duplicate of this bug. ***

Comment 3

[Asa Dotzler [:asa]]

Mike and Mike, can you all look into this. It's kind of ugly. I realize it's
probably too late for 1.5, but perhaps we can get this into a 1.5.1.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

I tried (and failed) to figure out where the code for this window lives, hoping
that it would be relatively trivial to add a cancel button. As ugly as it is, I
don't think this should block 1.5 release, though. The dialog doesn't block
firefox, so it's possible for the user to interact with the browser before
closing it or hitting OK. I'll look into it some more a little later tonight.

Comment 5

[Benjamin Smedberg]

I'm pretty sure this is just done with MessageBox call at
http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/installer/windows/wizard/setup/extra.c#6795

Have fun unwinding all the twisty paths there...

Comment 6

[Robert Strong (they/them - no direct email)]

This was fixed by converting to using the NSIS based installer - bug 326580. resolving -> wfm