268128 - inconsistent wording in custom install for descriptions of optional components

Status: RESOLVED WORKSFORME

(Firefox :: Installer, defect)

Description

[(not reading, please use [e-mail] instead)]

inconsistent wording in custom install for descriptions of optional components

I did a custom install of FF 1.0 rc2 and here's the descriptions for the
optional components


Developer Tools
	The Document Inspector - a tool for web developers.
Quality Feedback Agent
	for reporting Firefox crash information

Notice how the two descriptions don't have the same sentence structure or
punctuation.

Maybe for "Quality Feedback Agent"
        Talkback - a tool for reporting Firefox crash information.

Comment 1

[(not reading, please use [e-mail] instead)]

tbird has a similar issue, see #268127

Comment 2

[u88484]

Attachment: patch

Patch includes:

 #define QFA_SHORT Quality Feedback Agent
-#define QFA_LONG for reporting $ProductShortName$ crash information
+#define QFA_LONG Talkback - a tool for reporting Firefox $ProductShortName$
crash information.
 
 #define RPT_SHORT Website Reporter
-#define RPT_LONG for reporting $ProductShortName$ website compatibility
problems
+#define RPT_LONG Report Broken Web Site - a tool for reporting
$ProductShortName$ website compatibility problems.

Comment 3

[u88484]

Attachment: patch for browser v2.0

Comment 4

[u88484]

Attachment: patch for calendar

Comment 5

[u88484]

Attachment: patch for mail

Comment 6

[u88484]

Attachment: patch for xpinstall

Comment 7

[u88484]

Comment on attachment 194932 [details] [diff] [review]
patch for mail

I attachted an updated patch to bug# 268127

Comment 8

[Asa Dotzler [:asa]]

not a blocker but we'd be willing to consider a patch. I'm assuming that this
wouldn't have L10n impact since it wouldn't be absolutely necessary to make this
change in locales if their wording is ok.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

If we're going to fix this, we should do it right. Your patch solves one problem
(inconsistent formatting) but the descriptions as they are now don't add a lot
of value. I'd suggest the following changes instead:

-#define ADT_LONG The Document Inspector - a tool for web developers.
+#define ADT_LONG Installs th DOM Inspector which allows web developers to view
and analyze the structure of HTML, XML and XUL documents.

-#define QFA_LONG for reporting $ProductShortName$ crash information
+#define QFA_LONG Installs Talkback utility that assists the $ProductShortName$
developers by sending diagnostic reports if a program crash occurs.

-#define RPT_LONG for reporting $ProductShortName$ website compatibility problems
+#define RPT_LONG Installs a tool that allows users to report websites which are
not displayed properly in $ProductShortName$.

Comment 10

[Robert Strong (they/them - no direct email)]

The strings used by the NSIS based installer are:
DEV_TOOLS_DESC=A tool for inspecting the DOM of HTML, XUL, and XML pages, including the browser chrome.
QFA_DESC=A tool for submitting crash reports to Mozilla.org.

Also, this page won't be displayed if / when DOMi is removed.

resolving -> wfm

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 194930 [details] [diff] [review]
patch for browser v2.0

clearing review requests

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 194931 [details] [diff] [review]
patch for calendar

clearing review requests

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 194933 [details] [diff] [review]
patch for xpinstall

clearing review requests