268166 - Add spanish wikipedia search engine to es-ES build for firefox 1.x

Status: VERIFIED FIXED

(Mozilla Localizations :: es-ES / Spanish, defect)

Description

[Oscar Manuel Gómez Senovilla]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; es-ES; rv:1.7.3) Gecko/20040913
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; es-ES; rv:1.7.3) Gecko/20040913

Spanish community has asked this popular engine to be included in firefox 1.0

Reproducible: Always
Steps to Reproduce:

Comment 1

[Oscar Manuel Gómez Senovilla]

Attachment: src file for spanish wikipedia

Comment 2

[Oscar Manuel Gómez Senovilla]

Attachment: png file for spanish wikipedia

Comment 3

[Oscar Manuel Gómez Senovilla]

This bug is getting overlooked, and since the flag is not set, it can't be
commited. This way, though the bug was filed in time, it will be out. Please
give instructions where necessary if you still find this possible to be included.

Comment 4

[David A. Wheeler]

Note that this is a special case of the more general request
in Bug 269198 - which suggests that Wikipedia should be one of the
search engines that comes with Firefox, REGARDLESS of the language.

Comment 5

[Carey Evans]

Attachment: Fixed search plugin for Spanish Wikipedia

The attached Wikipedia plugin is buggy; es.wikipedia.org has used UTF-8 for
quite some time now, the search URL is old and the offset parameter causes
problems.  This new attachment fixes these problems.

If Wikipedia's full text search remains disabled, the [input name="fulltext"
value="fulltext"] line may be removed completely.

Comment 6

[Oscar Manuel Gómez Senovilla]

I've tried just today the files initially attached, and they work ok for me.
I've tried from ff 1.0.4 es-ES in linux, and the default charset is iso-8859-1.
I've tried searches using non-ascii text:

- Typing "España" takes me to http://es.wikipedia.org/wiki/Espa%C3%B1a
- Typing "ibérico" takes me to
http://es.wikipedia.org/w/wiki.phtml?search=ib%E9rico&sourceid=Mozilla-search&offset=0&offset=0

In all cases, I see the pages use utf-8, with the declaration perfectly ok in
the head section, so everything can be read with no problem.

I've commented this with Axel in IRC, and I've added him (to his request) to CC
in this bug. According to his questions and my replies, it seems that any
previous issue with charsets or anything else is now solved. I change the
summary replacing "1.0" with "1.x".

Comment 7

[Axel Hecht]

Comment on attachment 164938 [details]
src file for spanish wikipedia

I still think that the charsets should be UTF-8 in both cases, as that is the
default encoding on wikipedia now.

(Of course, sourceid is completely useless, too.)

Could you please try that? And submit a fixed version to mycroft, if I'm right?

Comment 8

[Oscar Manuel Gómez Senovilla]

Just for information, since now bug owner is knocte, I've tried both versions of
the plugin (the old as first attachment to the bug, and the newer as the last
attachment to the bug) and they work for me. I've found a difference in
funcionality, because when typing "españa", in the old src that took me directly
to the specific page commented previously, but the second takes me to a search
page with that word as search term.

Personally, I don't mind one or another, since they both work. But taking that
the old one wasn't blessed, it might be better to go for the new one.

Comment 9

[Andrés G. Aragoneses]

Added this to CVS.

Tried the last nightly and it works as expected (including special Spanish
characters: I have searched for "España" and it works).

Marking Resolved->Fixed for the moment.

Comment 10

[Axel Hecht [:Pike]]

Please change the search plugin to use UTF-8 encoding.

Re #8, one of the plugins uses 
<input name="fulltext" value="fulltext">
which accounts for the difference in search results.

That omgs' searches worked for iso-8859-1 is a coincidence, because utf-8 is based
on that charset. But if somebody tried to paste non-spanish words there, you'll
end up with badly encoded results.

Comment 11

[Andrés G. Aragoneses]

Do you want me to change the line of the charset only or to replace the whole
.src file with the attachment labeled "Fixed search plugin for Spanish Wikipedia"?

Comment 12

[Axel Hecht [:Pike]]

That's up to you, depending on what you want.
There is a conceptual difference between the two, one is good if you're searching
for topic, the other one is good if you're looking for related topics.

Comment 13

[Andrés G. Aragoneses]

Fix checked in:

Checking in wikipedia-es.src;
/l10n/l10n/es-ES/browser/searchplugins/Attic/wikipedia-es.src,v  <-- 
wikipedia-es.src
new revision: 1.1.2.2; previous revision: 1.1.2.1
done


I'll check in the next build if it keeps working.

Comment 14

[Axel Hecht [:Pike]]

If this works, could you land it on the trunk, too?

Comment 15

[Andrés G. Aragoneses]

It works perfectly in Firefox Beta 1. I will land it on the trunk ASAP.

Comment 16

[Axel Hecht [:Pike]]

Is this bug still open?

Comment 17

[Andrés G. Aragoneses]

It could be said that is RESOLVED for 1.8 branch and OPEN for trunk because I haven't applied the commit in the main branch yet.

Comment 18

[RickieES aka Ricardo Palomares]

(In reply to comment #17)
> It could be said that is RESOLVED for 1.8 branch and OPEN for trunk because I
> haven't applied the commit in the main branch yet.
> 


Wikipedia-es is now on trunk and we have nightlies to test it, so we can finally close this.

Comment 19

[RickieES aka Ricardo Palomares]

Verified it works on trunk.